Remove is_finite and is_normal intrinsics. #841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL removes the is_finite and is_normal intrinsics. In order to convert them into the OpIsFinite and OpIsNormal in SPIR-V the Kernel capability is required. The Kernel capability requires a Kernel execution mode. We do not use the Kernel execution mode but the GLCompute execution mode for compute shaders. If these methods are desired, they'll need to be added to the standard library.
kvark
approved these changes
Jun 4, 2020
kdashg
approved these changes
Jun 9, 2020
|
Discussed at the 2020-06-09 meeting. |
|
Closing this for now. Instead of removing, will put up a new PR which translates the is_finite and is_normal into the more complex SPIR-V representations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL removes the is_finite and is_normal intrinsics. In order to
convert them into the OpIsFinite and OpIsNormal in SPIR-V the Kernel
capability is required. The Kernel capability requires a Kernel
execution mode. We do not use the Kernel execution mode but the
GLCompute execution mode for compute shaders.
If these methods are desired, they'll need to be added to the standard
library.