[wgsl] Add text around entry point function. #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
reviewed
Jul 6, 2020
| @@ -988,6 +988,8 @@ file. | |||
| The input and output parameters to the entry point are determined by which | |||
| global variables are used in the function and any called functions. | |||
|
|
|||
| The entry point function must be declared with no arguments and returning `void`. | |||
There was a problem hiding this comment.
much related to #889 (comment) :)
dneto0
approved these changes
Jul 14, 2020
|
Discussed at the 2020-07-14 meeting. Resolved to accept this PR. |
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
In this PR the vertex step mode vertex buffer OOB validation in draw calls is tested. It test that encoder.draw will validate vertex step mode vertex buffer satisfing `bound size >= (strideCount - 1) * arrayStride + lastStride` iif strideCount > 0, and other draw call types do not validate vertex step mode vertex buffer OOB. Issue: gpuweb#906
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
This PR shorten the parameter names of webgpu:api,validation,encoding,cmds,render,draw:vertex_buffer_OOB, making sure that the full test case names with paramters are no longer than 200. If the test case name is too long, it will cause name of artifact logging file exceed the file name length limitation in Linux. Issue: gpuweb#906
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds restrictions on the WGSL entry point functions to accept no
parameters and to return void.
Fixes #778
Issue #889