-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify default offset and size for getMappedRange #908
Conversation
20930e1
to
4c5e97f
Compare
4c5e97f
to
773dcbf
Compare
for validation rules to apply. I have added an issue for the same at the moment. |
For the meeting, here's a concrete version of the proposal that I made above: Two overloads:
Eliminates ambiguities about what size=0 means, etc. and eliminates an (honestly useless) overload of this function. |
Resolution: getMappedRange(optional GPUSize64 offset = 0, optional GPUSize64 size), with:
|
So in case |
Correct! |
Small unresolved thing (didn't realize before): we should figure out whether it's
We can talk about this at the editors meeting in an hour. |
This one, to keep the signalling out of band. |
@kunalmohan Do you want to take care of this revision work, or would you like someone else to take care of it? Editors would be happy to take it. |
I would like to take a stab at it :) |
773dcbf
to
fed0797
Compare
fed0797
to
cc52518
Compare
cc52518
to
389b8af
Compare
You can view my nits commit without whitespace changes: 369b83a?diff=split&w=1 |
Not sure what your concern here was. I would interpret such a case to be using Also, not completely sure but we might consider changing the language in |
As written:
it would mean:
but the "offset > this.size" case has to be an error. |
You're right about mapAsync needing a fix too. |
Ohh..I see. Thank you for clarifynig! |
Oops, I misread this - I think you're right the original case I pointed out would have been caught correctly. But the opposite issue (size undefined and offset ≥ this.size) was still there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing from me
Defaults are specified w.r.t buffer
mapping_range
.While setting the default size,
offset
is checked with only lower bound inclusion to prevent zero-sized array buffers to be returned.Preview | Diff