Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump jsonwebtoken to 9.0.2 #78

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

Signed-off-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@wolfy1339
Copy link

Although this fix is fine, npm should be able to pick this version up as it's a patch version, and the dependency in this package is set to accept any version within the major version number.

Copy link
Owner

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@gr2m gr2m merged commit b8c43b2 into gr2m:1.x Jan 4, 2024
2 checks passed
@gr2m
Copy link
Owner

gr2m commented Jan 4, 2024

something's wrong with the release automation:
https://github.com/gr2m/universal-github-app-jwt/actions/runs/7405964716/job/20149666339

I'm looking into it

Copy link

github-actions bot commented Jan 4, 2024

🎉 This PR is included in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nitrocode nitrocode deleted the bump-jsonwebtoken branch January 4, 2024 05:54
@nitrocode
Copy link
Author

@gr2m thanks for fixing it

I noticed that the new version is shown as the latest. That's probably not intentional since there is a 2.x which is probably more recent.

@nitrocode
Copy link
Author

@wolfy1339 I tried doing an npm install for a package that uses this package but this package would still use 9.0.0 instead of 9.0.2 unless I explicitly updated it. Perhaps it's because of the package-lock.json file or perhaps I'm doing something wrong?

Thanks for merging anyway. This at least gets snyk to stop complaining 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants