Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar with events that have "null" location variables raise exceptions #2

Open
vilhelmprytz opened this issue Oct 6, 2020 · 0 comments
Open

Calendar with events that have "null" location variables raise exceptions #2

vilhelmprytz opened this issue Oct 6, 2020 · 0 comments

Comments

@vilhelmprytz
Copy link

vilhelmprytz commented Oct 6, 2020 •
edited
Loading

I have a .ics file that has events that do not have a location value, they are null. These .ics files are not renderable with this. See the error message.

error_message

It seems like Chrome is complaining about this line, line 126 in embed.js.

if (event.location.startsWith('http')) {

I have already fixed this, see linked PR (#3).
vilhelmprytz added a commit to vilhelmprytz/modern-cal-embed that referenced this issue Oct 6, 2020
@vilhelmprytz
Only show location if event.location is not empty and not null
d495715 
* not checking if `event.location` is `null` would cause exceptions for calendars that contain null location variables

fixes GRA0007#2
@vilhelmprytz vilhelmprytz mentioned this issue Oct 6, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vilhelmprytz