Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ruby post-install hook was not run for slim images #31

Closed
eregon opened this issue Nov 16, 2021 · 4 comments
Closed

The ruby post-install hook was not run for slim images #31

eregon opened this issue Nov 16, 2021 · 4 comments
Assignees

Comments

@eregon
Copy link
Member

eregon commented Nov 16, 2021

As we can see
https://github.com/graalvm/container/blob/952ceb4186763bd79c340b636adf89ca7267d2a5/truffleruby/Dockerfile.ol8-slim
doesn't run it, unlike

RUN /opt/truffleruby-$GRAALVM_VERSION-linux-amd64/lib/truffle/post_install_hook.sh

This then cause errors whenever the openssl gem is used, including just loading the gem.

Probably the easiest fix is to build the slim images from the non-slim images, and just don't copy the lib/llvm-toolchain.
Alternatively, installing the necessary packages to run the post-install hook, run it and uninstalling these packages might be another way.

@eregon
Copy link
Member Author

eregon commented Nov 23, 2022

This is still not fixed (EDIT: my mistake, I confused this with the RPM issue).

@eregon
Copy link
Member Author

eregon commented Nov 25, 2022

Slim and non-slim truffleruby Docker images for 22.3.0 now work on ol7 (uses /lib64/libssl.so.10), ol8 (uses /lib64/libssl.so.1.1), ol9 (uses /lib64/libssl.so.3), great!

@eregon eregon closed this as completed Nov 25, 2022
@eregon
Copy link
Member Author

eregon commented Nov 25, 2022

2cb1a08#diff-84f2742614cf3abb76ac4f64e9b684a87dfb410468d883020f867f141605bd63 is the fix (for truffleruby/Dockerfile.ol8-slim).

The trade-off is that installs openssl-devel gcc make extra, which is no longer needed after running and that adds quite a bit of size (around 100-200MB IIRC).

@eregon
Copy link
Member Author

eregon commented Nov 25, 2022

I filed #68 for the size increase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants