Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presentation points #33

Closed
5 tasks done
grace-joh opened this issue Feb 22, 2023 · 0 comments
Closed
5 tasks done

Presentation points #33

grace-joh opened this issue Feb 22, 2023 · 0 comments

Comments

@grace-joh
Copy link
Owner

grace-joh commented Feb 22, 2023

### Presentation points:

  • Demonstration of functional completeness

    • Run runner
      • start menu
        • quit /run again
        • invalid
        • start
      • Play Game
      • user wins (invalid input example)
      • play again/reset
      • Computer Win video****
      • Draw video
        • column full at 1:04
        • draw shown at the end
  • Technical quality and organization of the code (show Miro)

    • We started with Player/Computer, Board, and Game classes.
      • We built a flow chart to determine how the game plays, loops, and ends with consideration of edge cases.
      • We brainstormed all attributes and methods we might need based on the flow chart and rearranged them by Class.
      • We decided to make a Turn class.
    • Is there a design decision that you made that you’re particularly proud of?
      • Margaret - being able to move the win methods from Board to Game
      • Grace - the overall design process to figure out everything we needed and organizing them by class
  • Identifying code that should be refactored and how it would be refactored

    • We asked a mentor to review. He led us to want a Printer class that can take care of any output methods in Game. Also was excited about the extensions in Iteration 4 but did not get to them.
    • Diagonal win method(isn't readable), or all of the win methods?
      • Hesitant about a hash for the board layout structure (maybe use a nested array instead to access each index and count spaces, etc.)
      • Turn class with its relationship with Game and Board
  • Discussion of test coverage

    • Examples of a unit and an integration test: The board tests for win? with the horizontal/vertical/diagonal
    • Run your tests
  • Discussion of Pairing/version control

    • How did you all work together? Did you use a particular pairing technique?
      • Driver/Navigator, but also split tasks
      • Document all ideas and decisions with Miro/Project Board, made PR template to communicate our addition/changes, communicated with daily standups and multiple check-ins
    • Walk us through your GitHub insights.
      • 28 PRs
    • How many commits did you make?
      • 71 + 62
    • Can you identify a PR that was made that demonstrates good commenting/partner review workflow?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

1 participant