-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demonstrate using dynamic versions in the Convention Develocity samples #1272
Conversation
9b06d19
to
32ca33e
Compare
convention-develocity-gradle-plugin/examples/gradle_6.9_and_later/settings.gradle
Outdated
Show resolved
Hide resolved
convention-develocity-gradle-plugin/examples/gradle_6.9_and_later/settings.gradle
Outdated
Show resolved
Hide resolved
5d28fef
to
f8554c8
Compare
> [!IMPORTANT] | ||
> Using version ranges should only be done when releases and development versions are published to separate repositories. | ||
> Not having this separation introduces the risk that consumers will use a development version of the extension not yet ready to be used. | ||
> In these scenarios, using a static version is preferred. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convention-develocity-gradle-plugin/examples/gradle_6.9_and_later/settings.gradle
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Everything I mention here is a nitpick and can be ignored 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the addition of gradle_6.9_and_later
, the gradle_6
sample may be a little misleading. A Gradle 6.9 user may find and use the gradle_6
sample since, by name, it applies to them as well.
The sample will still work for them here, and I worry that clarify the gradle_6
sample to something like gradle_6.0_through_6.8
just adds verbosity without much benefit. So the best route may just be to keep the name as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point, but personally I prefer the simplicity.
3ec3fcc
to
4612e5d
Compare
264f19e
to
4ec80dd
Compare
This improves the Convention Develocity samples with examples and documentation for using dynamic versions.