Demonstrate using dynamic versions in the Convention Develocity samples #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichaagdev
changed the title
erichaagdev
force-pushed
the
erichaagdev/conventions-dynamic-versions
branch
from
9b06d19
to
32ca33e
Compare
erichaagdev
commented
Jun 21, 2024
convention-develocity-gradle-plugin/examples/gradle_6.9_and_later/settings.gradle
Outdated
Show resolved
Hide resolved
etiennestuder
requested changes
Jun 21, 2024
convention-develocity-gradle-plugin/examples/gradle_6.9_and_later/settings.gradle
Outdated
Show resolved
Hide resolved
erichaagdev
force-pushed
the
erichaagdev/conventions-dynamic-versions
branch
from
5d28fef
to
f8554c8
Compare
erichaagdev
commented
Jun 21, 2024
erichaagdev
commented
Jun 21, 2024
Comment on lines
+29
to
+32
| > [!IMPORTANT] | ||
| > Using version ranges should only be done when releases and development versions are published to separate repositories. | ||
| > Not having this separation introduces the risk that consumers will use a development version of the extension not yet ready to be used. | ||
| > In these scenarios, using a static version is preferred. |
convention-develocity-gradle-plugin/examples/gradle_6.9_and_later/settings.gradle
Outdated
Show resolved
Hide resolved
clayburn
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
With the addition of gradle_6.9_and_later, the gradle_6 sample may be a little misleading. A Gradle 6.9 user may find and use the gradle_6 sample since, by name, it applies to them as well.
The sample will still work for them here, and I worry that clarify the gradle_6 sample to something like gradle_6.0_through_6.8 just adds verbosity without much benefit. So the best route may just be to keep the name as-is.
There was a problem hiding this comment.
I see your point, but personally I prefer the simplicity.
erichaagdev
force-pushed
the
erichaagdev/conventions-dynamic-versions
branch
from
3ec3fcc
to
4612e5d
Compare
etiennestuder
requested changes
Jun 27, 2024
erichaagdev
force-pushed
the
erichaagdev/conventions-dynamic-versions
branch
from
264f19e
to
4ec80dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the Convention Develocity samples with examples and documentation for using dynamic versions.