Rename Gradle Enterprise to Develocity #1031
Conversation
Job Summary for gradle-build-actionDemo adding Build Scan® comment to PR :: successful-build-with-always-commentNo Gradle build results detected. |
3 similar comments
Job Summary for gradle-build-actionDemo adding Build Scan® comment to PR :: successful-build-with-always-commentNo Gradle build results detected. |
Job Summary for gradle-build-actionDemo adding Build Scan® comment to PR :: successful-build-with-always-commentNo Gradle build results detected. |
Job Summary for gradle-build-actionDemo adding Build Scan® comment to PR :: successful-build-with-always-commentNo Gradle build results detected. |
Co-authored-by: Guy Brand <guy@guymas.ch>
Job Summary for gradle-build-actionDemo adding Build Scan® comment to PR :: failing-build-with-comment-on-failure
|
Job Summary for gradle-build-actionDemo adding Build Scan® comment to PR :: successful-build-with-always-comment
|
There was a problem hiding this comment.
Looks good in general.
The develocity-injection test is failing: I'm pretty sure this is due to the incorrect secret name being used in integ-test-inject-develocity.yml.
My only other comment is regarding the use of develocity.gradle.org as the example URL in the README.
| DEVELOCITY_URL: https://ge.solutions-team.gradle.com | ||
| DEVELOCITY_PLUGIN_VERSION: 3.16.1 | ||
| DEVELOCITY_CCUD_PLUGIN_VERSION: 1.12.1 | ||
| DEVELOCITY_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }} |
There was a problem hiding this comment.
I'm pretty sure this needs to be secrets.DEVELOCITY_ACCESS_KEY, since that's the name of the secret as passed to this workflow.
README.md
Outdated
| GRADLE_ENTERPRISE_PLUGIN_VERSION: 3.16.1 | ||
| GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_KEY }} # Required to publish scans to ge.gradle.org | ||
| DEVELOCITY_INJECTION_ENABLED: true | ||
| DEVELOCITY_URL: https://develocity.gradle.org |
There was a problem hiding this comment.
Are we planning to rename this server soon? As far as I can tell it's still ge.gradle.org.
Since this is just an example, perhaps we should instead use something like https://develocity.your-server.com rather than a real-world server.
There was a problem hiding this comment.
I think having a dummy server like https://develocity.your-server.com is much preferred here as this is just an example.
I've updated this accrodingly.
README.md
Outdated
| | DEVELOCITY_ENFORCE_URL | | enforce the configured Develocity URL over a URL configured in the project's build; set to _true_ to enforce publication of build scans to the configured Develocity URL | | ||
| | DEVELOCITY_PLUGIN_VERSION | :white_check_mark: | the version of the [Develocity Gradle plugin](https://docs.gradle.com/enterprise/gradle-plugin/) to apply | | ||
| | DEVELOCITY_CCUD_PLUGIN_VERSION | | the version of the [Common Custom User Data Gradle plugin](https://github.com/gradle/common-custom-user-data-gradle-plugin) to apply, if any | | ||
| | DEVELOCITY_PLUGIN_REPOSITORY_URL | | the URL of the repository to use when resolving the Develocity and CCUD plugins; the Gradle Plugin Portal is used by default | |
There was a problem hiding this comment.
I'd like to rename this to GRADLE_PLUGIN_REPOSITORY_URL, since it makes no sense to have different env vars to configure the plugin portal for the DV plugins and the dependency-graph plugin.
I'll take care of this in a subsequent change, if necessary.
Job Summary for gradle-build-actionDemo adding Build Scan® comment to PR :: failing-build-with-comment-on-failure
|
Job Summary for gradle-build-actionDemo adding Build Scan® comment to PR :: successful-build-with-always-comment
|
- Use `develocity.your-server.com` consistently in examples - Remove access key from example, since it's unrelated to the actual DV injection (And the access key name remains at `GRADLE_ENTERPRISE_ACCESS_KEY`)
GE plugin 3.16.1 still expects the access key to be provided via the `GRADLE_ENTERPRISE_ACCESS_KEY` env var.
Job Summary for gradle-build-actionDemo adding Build Scan® comment to PR :: successful-build-with-always-comment
|
Job Summary for gradle-build-actionDemo adding Build Scan® comment to PR :: failing-build-with-comment-on-failure
|
No description provided.