-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending an already resolved configuration no longer works correctly #24109
Labels
Milestone
Comments
bot-gradle
added a commit
that referenced
this issue
Mar 2, 2023
…ations The hierarchy is saved as an instance variable in configuration metadata. The mutation type for configuration extension was DEPENDENCIES, which only caused the cached metadata to be reevaluated. This is not sufficient. We add a new mutation type for HIERARCHY which completely discards the metadata, allowing it to be recalculated and the new hierarchy value to be passed to the configuration metadata Fixes #24109 Co-authored-by: Justin Van Dort <jvandort@gradle.com>
Fix has been merged |
Thanks! Will there be a backport to 7.x with this fix? |
Filed #24132 for this |
This was referenced Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
Extending an already resolved configuration should include the resolved dependencies of that configuration in the sub configuration.
Current Behavior
Dependencies from the already resolved super configuration are not included in the sub configuration.
Context
This stopped working in Gradle 7.6.1 and 8.0 (also tested with 8.0.1). I noticed this issue with our fork of the fabric-loom gradle plugin. Because of the complex nature of the plugin a lot of things are done "out of order". A simple workaround for this issue exists (adding an
extendsFrom
in the buildscript/earlier in the plugin).Steps to Reproduce
Run the following buildscript:
Note the difference in output between gradle 7.6
and 7.6.1
Your Environment
Build scan URL (Gradle 7.6): https://scans.gradle.com/s/uqo7kw7crp4fq
Build scan URL (Gradle 7.6.1): https://scans.gradle.com/s/mpjt6aujq3loc
The text was updated successfully, but these errors were encountered: