Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid version resolved for 1.+ when dependency locking is enabled #6337

Closed
bigdaz opened this issue Aug 10, 2018 · 0 comments
Closed

Invalid version resolved for 1.+ when dependency locking is enabled #6337

bigdaz opened this issue Aug 10, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@bigdaz
Copy link
Member

bigdaz commented Aug 10, 2018

If a dependency locking is enabled for a project, dependency versions defined with N.+ are resolved as per + when the lock file is updated.

Expected Behavior

Dependency locking is enabled and Gradle is executed with --write-locks, then a version selector like 1.+ is resolved in the same way as when dependency locking is not enabled. Given available versions [1.0, 1.1, 2.0], 1.+ should resolve to 1.1.

Current Behavior

Version selectors like 1.+ are resolve as per + when dependency locking is enabled. Given available versions [1.0, 1.1, 2.0], 1.+ will resolve to 2.0.

@bigdaz bigdaz added this to the 4.10 RC2 milestone Aug 10, 2018
@bigdaz bigdaz self-assigned this Aug 10, 2018
bigdaz added a commit that referenced this issue Aug 11, 2018
A bug was causing a selector like `1.+` to select _any_ version
when dependency locking was enabled. This change fixes this so that
only versions that match the selector will be chosen.

Fixes #6337
@bigdaz bigdaz closed this as completed in 61f3544 Aug 11, 2018
bigdaz added a commit that referenced this issue Aug 11, 2018
A bug was causing a selector like `1.+` to select _any_ version
when dependency locking was enabled. This change fixes this so that
only versions that match the selector will be chosen.

Fixes #6337
OdysseusLives added a commit to nebula-plugins/gradle-nebula-integration that referenced this issue Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant