Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run AGP tests with versions 3.5.2 and 3.6.0-beta03 #11261

Merged
merged 5 commits into from
Nov 11, 2019

Conversation

lptr
Copy link
Member

@lptr lptr commented Nov 7, 2019

No description provided.

@lptr lptr added this to the 6.1 RC1 milestone Nov 7, 2019
@lptr lptr requested a review from wolfs November 7, 2019 15:11
@lptr lptr self-assigned this Nov 7, 2019
Copy link
Member

@wolfs wolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we update this version as well:

ref.set("036aad22af993d2f564a6a15d6a7b9706ba37d8e")
?

@lptr lptr force-pushed the lptr/android/upgrade-to-agp-3.5.2-and-3.6.0-beta03 branch from da858f9 to 3fb0d09 Compare November 7, 2019 17:43
@lptr lptr requested a review from wolfs November 7, 2019 17:49
Copy link
Member

@wolfs wolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added some questions to the PR which are not necessarily related to it.

"Type 'DependencyTask': field 'configurations' without corresponding getter has been annotated with @Input. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0.",
"Type 'DependencyTask': field 'outputDir' without corresponding getter has been annotated with @OutputDirectory. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0.",
"Type 'DependencyTask': field 'outputFile' without corresponding getter has been annotated with @OutputFile. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0.",
"Type 'LicensesTask': field 'dependenciesJson' without corresponding getter has been annotated with @InputFile. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we remove the LicenseTask from the santa-tracker build: gradle/santa-tracker-android@d4d6b24

That might also explain why the DependencyTask doesn't show up any more.

Note that the plugin is not part of AGP, so I think it is fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've submitted a PR for the licenses plugin here: google/play-services-plugins#111

@lptr lptr requested a review from wolfs November 8, 2019 17:07
@lptr lptr merged commit cac3a0a into master Nov 11, 2019
@lptr lptr deleted the lptr/android/upgrade-to-agp-3.5.2-and-3.6.0-beta03 branch November 11, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants