Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards Scala 3 support. #18003

Closed
wants to merge 1 commit into from
Closed

Towards Scala 3 support. #18003

wants to merge 1 commit into from

Conversation

dubinsky
Copy link

Fixes #16527, #15491

  • switch to the latest Zinc;
  • detect Scala 3 library dependency;
  • configure Scala 3 compiler and bridge as appropriate;
  • Scala 3 compiler bridge is distributed as a binary and does not need to be compiled.

Context

Contributor Checklist

  • Review Contribution Guidelines
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
  • Provide unit tests (under <subproject>/src/test) to verify logic
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes
  • Ensure that tests pass sanity check: ./gradlew sanityCheck
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation
  • Recognize contributor in release notes

@dubinsky dubinsky marked this pull request as draft August 11, 2021 17:37
@SethTisue
Copy link

are this and #18001 independent efforts?

@dubinsky
Copy link
Author

are this and #18001 independent efforts?

Yes, they are.

@@ -300,6 +300,7 @@ public void execute(ScalaBasePlugin scalaBasePlugin) {

// exclude the dependencies already provided by SCALA_CONTAINER; prevents problems with Eclipse Scala plugin
project.getGradle().projectsEvaluated(gradle -> {
// TODO: support Scala3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eclipse will not currently work anyway :/ so no need to update this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Signed-off-by: Leonid Dubinsky <dub@podval.org>
@dubinsky
Copy link
Author

The main goal of this pull request - support for Scala 3 - was not achieved: some classpath manipulations are needed, as demonstrated by #18001, which does makes Scala 3 work.

This pull request also attempts to update Zinc to the latest version. This turned out to be:

Clean-up of the Scala-library-version-recognizing code in the Scala plugin might get its own follow-up pull request (again, as suggested by @tgodzik in #18001 (comment)), but this change is less pressing and thus is less likely to happen :)

For the above reasons, this pull request is not relevant. Closing.

@dubinsky dubinsky closed this Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Scala3
3 participants