-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using version catalog plugins without version #18728
Conversation
❌ Contributor CI Build failed: https://ge.gradle.org/s/xdynfibit7uiq |
❌ Contributor CI Build failed: https://ge.gradle.org/s/7zwsumr6735y4 |
d3b9828
to
d801539
Compare
@bot-gradle test QFL |
OK, I've already triggered QuickFeedbackLinux build for you. |
@bot-gradle test this |
OK, I've already triggered ReadyForMerge build for you. |
I probably should also restrict |
Closed in favor of #19015 |
Fixes #18236
Fixes #18467
Changes:
alias("alias").toPluginId("id").withoutVersion()
, in TOML you can do any of:PluginDependencyProvider
that havegetWithoutVersion()
method, so you can do:alias
as default method due to 7.2: PluginDependenciesSpec interface adds non-default methods, thus breaking backward compatibility #18467I am not perfectly happy with
alias(libs.my.plugin.withoutVersion)
it feels verbose, but other solutions are trickier.Maybe alternative
alias(libs.my.plugin).withoutVersion()
could be interesting, but in that case we should change logic ofalias(libs.my.plugin).version(null)
: now it fails, but it could set version to unspecified. Interestingly docs ofPluginDependencySpec
already say that null does that.