Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default test suite behavior is no longer to use JUnit 4 #19471

Closed
wants to merge 2 commits into from

Conversation

tresat
Copy link
Member

@tresat tresat commented Jan 3, 2022

This is incorrectly noted here: https://docs.gradle.org/current/userguide/jvm_test_suite_plugin.html#sec:jvm_test_suite_tasks

This adds a new integration test to demonstrates this behavior. This is intentional, see:

if (!name.equals(JvmTestSuitePlugin.DEFAULT_TEST_SUITE_NAME)) {

This PR also adjust docs to note this.

- Add test to demonstrate this.
- Adjust docs to note this.
@tresat tresat requested a review from a team as a code owner January 3, 2022 15:35
@bot-gradle bot-gradle added this to the 7.5 milestone Jan 3, 2022
@tresat tresat modified the milestones: 7.5, 7.4 Jan 3, 2022
@tresat tresat requested review from big-guy and DPUkyle and removed request for a team January 3, 2022 15:36
@tresat tresat self-assigned this Jan 3, 2022
@tresat tresat added @core Issue owned by GBT Core in:test-suites Work related to the JvmTestSuite Plugin labels Jan 3, 2022
@tresat
Copy link
Member Author

tresat commented Jan 3, 2022

@bot-gradle test QFL

@bot-gradle
Copy link
Collaborator

OK, I've already triggered the following builds for you:

Copy link
Contributor

@DPUkyle DPUkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I could have sworn we set JUnit 4 as a fallback when nothing was specified.

This must have changed when we encountered difficulties changing the framework in multiple places, i.e. set options on the suite object, then later tweak on an individual Test task. Perhaps at this point we added the requirement to set the framework explicitly?

@tresat
Copy link
Member Author

tresat commented Jan 3, 2022

LGTM, though I could have sworn we set JUnit 4 as a fallback when nothing was specified.

We definitely did. Then the behavior changed, to deal with the options issues, I think, and we forgot to update the docs. Now the test should confirm and document the behavior as well, and we can stop confusing any users wondering about why this isn't working.

@big-guy big-guy changed the base branch from master to release January 5, 2022 20:06
@big-guy big-guy requested a review from pioterj as a code owner January 5, 2022 20:06
@big-guy big-guy changed the base branch from release to master January 5, 2022 20:07
@octylFractal
Copy link
Member

Reminder to retarget this at release for 7.4.

@tresat
Copy link
Member Author

tresat commented Jan 7, 2022

Replaced by #19505

@big-guy big-guy modified the milestones: 7.4, 7.4 RC1 Jan 17, 2022
@tresat tresat deleted the tt/74/default-test-suite-framework branch September 18, 2023 21:48
@ov7a ov7a removed this from the 7.4 RC1 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@core Issue owned by GBT Core in:test-suites Work related to the JvmTestSuite Plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants