-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default test suite behavior is no longer to use JUnit 4 #19471
Conversation
- Add test to demonstrate this. - Adjust docs to note this.
@bot-gradle test QFL |
OK, I've already triggered the following builds for you: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I could have sworn we set JUnit 4 as a fallback when nothing was specified.
This must have changed when we encountered difficulties changing the framework in multiple places, i.e. set options on the suite object, then later tweak on an individual Test task. Perhaps at this point we added the requirement to set the framework explicitly?
We definitely did. Then the behavior changed, to deal with the |
…plicitly on non-default test suites.
Reminder to retarget this at |
Replaced by #19505 |
This is incorrectly noted here: https://docs.gradle.org/current/userguide/jvm_test_suite_plugin.html#sec:jvm_test_suite_tasks
This adds a new integration test to demonstrates this behavior. This is intentional, see:
gradle/subprojects/plugins/src/main/java/org/gradle/api/plugins/jvm/internal/DefaultJvmTestSuite.java
Line 125 in 74fb3be
This PR also adjust docs to note this.