Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not stage libraries during install, instead append their parent to LD... #249

Closed
wants to merge 1 commit into from
Closed

Do not stage libraries during install, instead append their parent to LD... #249

wants to merge 1 commit into from

Conversation

adityakishore
Copy link

..._LIBRARY_PATH.

The current approach does not work anyway if used with certain external libraries, e.g. libjvm.

@bigdaz
Copy link
Member

bigdaz commented Feb 23, 2014

Thanks for the pull request. Unfortunately this change will break a lot of our tests, and cannot be applied as-is. It also is a bit too simplistic a solution to this problem.

One issue with adding all parent directories to LD_LIBRARY_PATH is that this means every sibling library of a referenced library is also made available.

I'm going to close this pull request. Please open a discussion on the Gradle developers list if you want to help with a more complete solution to this issue.

@bigdaz bigdaz closed this Feb 23, 2014
@adityakishore
Copy link
Author

Thanks for having a look . I agree that this is too simple and I had been thinking about the alternatives. Will take this to the dev list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants