Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable file-system watching on macOS 11 and before #29514

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

lptr
Copy link
Member

@lptr lptr commented Jun 12, 2024

File-system watching only works well on macOS 12+. This updates the documentation and automatically disables it on macOS 11 and earlier.

New native code that breaks on macOS 11 and earlier was introduced in 8.8 in:

Note: We don't have macOS 11 or earlier in our CI fleet, so we can't actually test this automatically.

Fixes #29476

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@lptr lptr added a:chore Minor issue without significant impact in:virtual-file-system VFS, file system watching, snapshots labels Jun 12, 2024
@lptr lptr added this to the 8.9 RC1 milestone Jun 12, 2024
@lptr lptr self-assigned this Jun 12, 2024
@lptr lptr requested review from a team as code owners June 12, 2024 07:23
@lptr
Copy link
Member Author

lptr commented Jun 12, 2024

@bot-gradle test QF please.

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@lptr lptr linked an issue Jun 12, 2024 that may be closed by this pull request
@lptr lptr changed the title Mention that macOS 12 is required for file-system watching Disable file-system watching on macOS 11 and before Jun 12, 2024
@lptr
Copy link
Member Author

lptr commented Jun 12, 2024

Manually tested here: https://github.com/lptr/kmp-viewmodel/actions/runs/9479024243/job/26116663434#step:7:34

Disabling file system watching on macOS 11.7.10, as it is only supported for macOS 12+
Using 3 worker leases.
Configuration on demand is an incubating feature.
Received JVM installation metadata from '/Users/runner/hostedtoolcache/Java_Zulu_jdk/21.0.3-9/x64': {JAVA_HOME=/Users/runner/hostedtoolcache/Java_Zulu_jdk/21.0.3-9/x64, JAVA_VERSION=21.0.3, JAVA_VENDOR=Azul Systems, Inc., RUNTIME_NAME=OpenJDK Runtime Environment, RUNTIME_VERSION=21.0.3+9-LTS, VM_NAME=OpenJDK 64-Bit Server VM, VM_VERSION=21.0.3+9-LTS, VM_VENDOR=Azul Systems, Inc., OS_ARCH=x86_64}
Watching the file system is configured to be enabled if available
File system watching is inactive

Looks to be working 🎉

Copy link
Member

@asodja asodja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@asodja asodja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lptr lptr added this pull request to the merge queue Jun 12, 2024
@bot-gradle
Copy link
Collaborator

WARN: Based on labels, this pull request addresses notable issue but no changes to release note found.

Merged via the queue into release with commit fc90029 Jun 12, 2024
10 checks passed
@lptr lptr deleted the lptr/file-watching/update-macos-requirements branch June 12, 2024 09:20
@dk-dkops
Copy link

dk-dkops commented Jul 2, 2024

Thank you so much for this fix !
Ran into this on OS X 10.15 with Gradle 8.8 ( tried every conceivable java and workaround - like a brick wall )
Tested 8.9 RC 1 - works like a charm !
Thank you ! It's good to have current / next Gradle available, and not resort to reverting and working around !
( As old and deprecated as OS X 10.15 is - there are those of us who still have to use it, and it's very appreciated )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:chore Minor issue without significant impact in:virtual-file-system VFS, file system watching, snapshots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle 8.8 crashed on MacOS 11.x (8.7 still works as expected)
4 participants