-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable file-system watching on macOS 11 and before #29514
Conversation
@bot-gradle test QF please. |
I've triggered the following builds for you. Click here to see all build failures. |
Manually tested here: https://github.com/lptr/kmp-viewmodel/actions/runs/9479024243/job/26116663434#step:7:34
Looks to be working 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WARN: Based on labels, this pull request addresses notable issue but no changes to release note found. |
Thank you so much for this fix ! |
File-system watching only works well on macOS 12+. This updates the documentation and automatically disables it on macOS 11 and earlier.
New native code that breaks on macOS 11 and earlier was introduced in 8.8 in:
Note: We don't have macOS 11 or earlier in our CI fleet, so we can't actually test this automatically.
Fixes #29476
Reviewing cheatsheet
Before merging the PR, comments starting with