GRADLE-796/673 Preserving permissions by default in copy/archive tasks #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ymlinkIntegrationTest.
…replicating the changes made to FileCollectionSymlinkIntegrationTest).
…he file. Implemented for regular files & archives.
Permissions are now preserved by default. They can still be set using fileMode/dirMode and can also be set on individual files using copy actions. FileCopySpecVisitor now honors file modes (implicitly through AbstractFileTreeElement.copyTo(..)) The actual permissions that will be used for any given file are exposed to copy actions. The actions can also set permissions using the new FileCopyDetails.setMode().
…eserved by default. Everything related to permissions during copying is covered in unit-test + CopyTaskPermissionsIntegrationTest.
…ew, nullable fileMode/dirMode. Updating the DSL docs with the new default values (null) for fileMode/dirMode.
|
This looks good. We're just working on getting 1.0-milestone-8 out of the door, so we'll apply the patch after milestone 8 is out. |
|
Ok good.. Found another issue that is fixed as well after this is merged... GRADLE-971 |
Conflicts: subprojects/core/src/main/groovy/org/gradle/api/file/CopyProcessingSpec.java
|
I just tried to resolve a conflict in CopyProcessingSpec. It's the first time I've done this with git, not sure if I was supposed to add those merge commits to the pull request.. |
|
Sweet.. GRADLE-971 can be closed as well.. |
|
Thanks for fixing this! |
ov7a
pushed a commit
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented changes as discussed on the mailing list.