New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstraction - Query Builder Component Selector #2

Closed

jbguerraz opened this issue Aug 31, 2020 · 0 comments · Fixed by #42

Labels

enhancement frontend

Contributor

jbguerraz commented Aug 31, 2020 •

edited

Loading

At the moment the "query builder component selector" components are mostly copy/paste (cf https://github.com/grafadruid/druid-grafana/blob/master/src/builder/query/Query.tsx and https://github.com/grafadruid/druid-grafana/blob/master/src/builder/datasource/DataSource.tsx for instance), it would be better to use an abstracted component "QueryBuilderComponentSelector" instead.

jbguerraz changed the title ~~Abstraction - Component Selector~~ Abstraction - Query Builder Component Selector

jbguerraz added the enhancement label

jbguerraz added the frontend label

jbguerraz mentioned this issue

refactor component selectors. abstraction (FC/Hooks/HoC). #42

Merged

jbguerraz closed this as completed in #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment