Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clustering: deal with gaps during cluster changes #249

Closed
Tracked by #784 ...
tpaschalis opened this issue Feb 8, 2024 · 3 comments · Fixed by #703
Closed
Tracked by #784 ...

clustering: deal with gaps during cluster changes #249

tpaschalis opened this issue Feb 8, 2024 · 3 comments · Fixed by #703
Assignees
Labels
bug Something isn't working enhancement New feature or request frozen-due-to-age

Comments

@tpaschalis
Copy link
Member

tpaschalis commented Feb 8, 2024

During cluster event changes, and when targets are being shuffled around, a target disappearing will make the underlying Prometheus code insert a staleness marker on the next scrape.

If no new scrapes (by the new target owner) has been made in the meantime, the staleness marker will appear as a gap in the graph.

Given how clustering is aiming to be a solution for dynamically scaling Grafana Agent, we should find a way to enhance staleness marker tracking to avoid gaps in graphs for series that continue their presence.

@tpaschalis tpaschalis changed the title Deal with gaps during cluster changes clustering: eal with gaps during cluster changes Feb 8, 2024
@tpaschalis tpaschalis changed the title clustering: eal with gaps during cluster changes clustering: deal with gaps during cluster changes Feb 8, 2024
Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@rfratto
Copy link
Member

rfratto commented Apr 11, 2024

Hi there 👋

On April 9, 2024, Grafana Labs announced Grafana Alloy, the spirital successor to Grafana Agent and the final form of Grafana Agent flow mode. As a result, Grafana Agent has been deprecated and will only be receiving bug and security fixes until its end-of-life around November 1, 2025.

To make things easier for maintainers, we're in the process of migrating all issues tagged variant/flow to the Grafana Alloy repository to have a single home for tracking issues. This issue is likely something we'll want to address in both Grafana Alloy and Grafana Agent, so just because it's being moved doesn't mean we won't address the issue in Grafana Agent :)

@rfratto rfratto transferred this issue from grafana/agent Apr 11, 2024
@andres-garcia-webbeds
Copy link

Also happening to us.
Metrics are inconsistent

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request frozen-due-to-age
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants