[integrations] Add udev data path arg to node_exporter #4481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
marctc
reviewed
Jul 17, 2023
Done. @marctc Let me know if something else is needed or if I've done something wrong (I'm off for the day, can take a look tomorrow). |
marctc
reviewed
Jul 17, 2023
sduranc
force-pushed
the
main
branch
2 times, most recently
from
17d1711
to
797a5b0
Compare
marctc
approved these changes
Jul 18, 2023
|
@marctc |
auto-merge was automatically disabled
July 18, 2023 13:56
Head branch was pushed to by a user without write access
sduranc
force-pushed
the
main
branch
3 times, most recently
from
9734061
to
66c8007
Compare
clayton-cornell
approved these changes
Jul 19, 2023
|
@marctc there's a merge conflict. I haven't tried resolving. Is this something for you to sort out, or? |
|
@sduranc could you fix merge conflicts and merget this PR? thanks! |
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Node exporter has added udev data to it's diskstats collector. It's possible to set up this path in node_exporter but right now we can't do the same in the grafana agent, so this PR just makes that available. Also, it appears that when node_exporter can't access the path it fails to create disk metrics. This has already been fixed in prometheus operator and in the helm chart.
Which issue(s) this PR fixes
It seems like it fixes #4207
Fixes #4517
Notes to the Reviewer
As far as I understand, no tests need to updated for this change. Please correct me if I'm wong.
PR Checklist