Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label normalisation in otelcol.exporter.loki #4920

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Fix label normalisation in otelcol.exporter.loki #4920

merged 2 commits into from
Aug 25, 2023

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Aug 24, 2023

PR Description

A few months ago we upgraded the version of Otel Collector which the Agent uses. This introduced a bug where otelcol.exporter.loki didn't normalize labels properly anymore.

Which issue(s) this PR fixes

Fixes #3928

Notes to the Reviewer

  • I think there is a metric which should be documented, but I don't have time to make sure we expose it. I'll document it later for all otelcol components via Document metrics of otelcol components alloy#384
  • After we upgrade to a version of collector which contains a fix for LogToLokiEntry, we can remove the code on our side which applies the labels. We should retain the tests though.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@ptodev ptodev requested review from a team and clayton-cornell as code owners August 24, 2023 13:40
@ptodev ptodev linked an issue Aug 24, 2023 that may be closed by this pull request
Document and verify Otlp -> Loki label translation #3928
Closed
@ptodev ptodev changed the title Add documentation and testing for otlp->loki label translation Fix label normalisation in otelcol.exporter.loki Aug 24, 2023
thampiotr
thampiotr approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@thampiotr thampiotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thampiotr thampiotr enabled auto-merge (squash) August 25, 2023 07:55
@thampiotr thampiotr merged commit 66bd910 into main Aug 25, 2023
8 checks passed
@thampiotr thampiotr deleted the 3928-document-and-verify-otlp-loki-label-translation branch August 25, 2023 07:59
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thampiotr thampiotr thampiotr approved these changes

@clayton-cornell clayton-cornell Awaiting requested review from clayton-cornell clayton-cornell is a code owner

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document and verify Otlp -> Loki label translation
2 participants
@ptodev @thampiotr