add nsis check for environment var #6185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikbaranowski
approved these changes
Jan 18, 2024
marctc
pushed a commit
that referenced
this pull request
Jan 19, 2024
* add nsis check for environment var * add changelog
marctc
added a commit
that referenced
this pull request
Jan 19, 2024
* add nsis check for environment var (#6185) * add nsis check for environment var * add changelog * chore(sec): fix vulns by bumping pkgs to patched ver (#6060) * chore(sec): fix vulns by bumping pkgs to patched ver Signed-off-by: hainenber <dotronghai96@gmail.com> * chore(doc): add CHANGELOG entry Signed-off-by: hainenber <dotronghai96@gmail.com> * fix(ci): accomodate func signature change Signed-off-by: hainenber <dotronghai96@gmail.com> --------- Signed-off-by: hainenber <dotronghai96@gmail.com> --------- Signed-off-by: hainenber <dotronghai96@gmail.com> Co-authored-by: mattdurham <mattdurham@ppog.org> Co-authored-by: Đỗ Trọng Hải <41283691+hainenber@users.noreply.github.com>
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
* add nsis check for environment var * add changelog
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Previously if the environment var existed the installer would fail. Likely in asking for confirmation to overwrite. This follows the pattern of Arguments reg key
Which issue(s) this PR fixes
Fixes #6179
Notes to the Reviewer
PR Checklist