Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL destination for Agent Operator CRDs #6241

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

clayton-cornell
Copy link
Contributor

PR Description

This PR updates the documented URL for the Agent Operator CRDs

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, not sure how I missed this one

@clayton-cornell clayton-cornell merged commit bc91e84 into main Jan 25, 2024
14 checks passed
@clayton-cornell clayton-cornell deleted the docs/update-link-operator-docs branch January 25, 2024 18:04
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other instances:

pkg/operator/operator_test.go
156  	crdPaths, err := filepath.Glob("../../production/operator/crds/*.yaml")

docs/sources/operator/helm-getting-started.md
30   In this section, you'll install the [grafana-agent-operator Helm chart](https://github.com/grafana/helm-charts/tree/main/charts/agent-operator) into your Kubernetes cluster. This will install the latest version of Agent Operator and its [Custom Resource Definitions](https://github.com/grafana/agent/tree/main/production/operator/crds) (CRDs). The chart configures Operator to maintain a Service that lets  ... (truncated)

docs/sources/operator/deploy-agent-operator-resources.md
148      - Sets a `cluster: cloud` label for all metrics shipped to your Prometheus-compatible endpoint. Change this label to your cluster name. To search for `MetricsInstances` or `LogsInstances` in a *different* namespace, use the `instanceNamespaceSelector` field. To learn more about this field, see the `GrafanaAgent` [CRD specification](https://github.com/grafana/agent/blob/main/production/op ... (truncated)
406      This example tails container logs for all Pods in the `default` namespace. You can restrict the set of matched Pods by using the `matchLabels` selector. You can also set additional `pipelineStages` and create `relabelings` to add or modify log line labels. To learn more about the `PodLogs` specification and available resource fields, see the [PodLogs CRD](https://github.com/grafana/agent/blob/main�[0m�[1 ... (truncated)

docs/sources/static/set-up/install/_index.md
41   For more information, refer to the [Tanka](https://tanka.dev) configurations in the Grafana Agent [production](https://github.com/grafana/agent/tree/main/production/tanka/grafana-agent) directory on GitHub.

cmd/grafana-agent-operator/DEVELOPERS.md
77   folder](../../production/operator/crds). Deploy them from the root of the

grafanabot pushed a commit that referenced this pull request Jan 25, 2024
(cherry picked from commit bc91e84)
@clayton-cornell
Copy link
Contributor Author

I'll grab those in another PR

@jdbaldry
Copy link
Member

I've not checked if all are relevant, I just searched for /production/ across the branch

@grafanabot
Copy link
Contributor

The backport to release-v0.37 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-6241-to-release-v0.37 origin/release-v0.37
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x bc91e84a7c4a7fcd9dffb04a6650a04284691968
# Push it to GitHub
git push --set-upstream origin backport-6241-to-release-v0.37
git switch main
# Remove the local backport branch
git branch -D backport-6241-to-release-v0.37

Then, create a pull request where the base branch is release-v0.37 and the compare/head branch is backport-6241-to-release-v0.37.

grafanabot pushed a commit that referenced this pull request Jan 25, 2024
(cherry picked from commit bc91e84)
grafanabot pushed a commit that referenced this pull request Jan 25, 2024
(cherry picked from commit bc91e84)
clayton-cornell added a commit that referenced this pull request Jan 25, 2024
(cherry picked from commit bc91e84)

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
clayton-cornell added a commit that referenced this pull request Jan 25, 2024
(cherry picked from commit bc91e84)

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
clayton-cornell added a commit that referenced this pull request Jan 26, 2024
* Update URL destination (#6241)

(cherry picked from commit bc91e84)

* trigger CI
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release-v0.37 backport release-v0.38 backport release-v0.39 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants