Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct syntax for var names in headings #6244

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

clayton-cornell
Copy link
Contributor

@clayton-cornell clayton-cornell commented Jan 25, 2024

PR Description

This PR adds the variables back to headings (changed in #6242 ). The correct syntax for shortcodes in headings is documented here: https://grafana.com/docs/writers-toolkit/write/shortcodes/#param

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@clayton-cornell clayton-cornell added type/docs Docs Squad label across all Grafana Labs repos backport release-v0.39 labels Jan 25, 2024
@clayton-cornell clayton-cornell requested a review from a team January 25, 2024 18:17
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obvious attempt to artificially increase your commit count 😉

@clayton-cornell clayton-cornell enabled auto-merge (squash) January 25, 2024 18:20
@clayton-cornell clayton-cornell merged commit d017470 into main Jan 25, 2024
12 checks passed
@clayton-cornell clayton-cornell deleted the docs/update-headings-variable-name branch January 25, 2024 18:22
@grafanabot
Copy link
Contributor

The backport to release-v0.39 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-6244-to-release-v0.39 origin/release-v0.39
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x d017470abd9364c10fb3ba70ae36e61c39378a60
# Push it to GitHub
git push --set-upstream origin backport-6244-to-release-v0.39
git switch main
# Remove the local backport branch
git branch -D backport-6244-to-release-v0.39

Then, create a pull request where the base branch is release-v0.39 and the compare/head branch is backport-6244-to-release-v0.39.

BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release-v0.39 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants