Fix heading remove variable #6242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayton-cornell
added
type/docs
rfratto
approved these changes
Jan 25, 2024
grafanabot
pushed a commit
that referenced
this pull request
Jan 25, 2024
(cherry picked from commit e1986b0)
|
I thought this worked with (https://grafana.com/docs/writers-toolkit/write/shortcodes/#param) |
|
Yeah in https://grafana.com/docs/agent/v0.39/flow/#grafana-agent-flow, the first heading is working and the second isn't. The difference is the use of |
|
Yeah, you're right... I forgot the fix even though I recently documented the fix in the Writer's Toolkit :-( |
4 tasks
clayton-cornell
added a commit
that referenced
this pull request
Jan 25, 2024
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR removes the
{{< param "PRODUCT_NAME" >}}Hugo shortcode from headings. If we use this shortcode in the heading text Hugo rewrites the anchor to say#hahahugoshortcodes3hbhbwherever the shortcode is used.Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist