Change the default value of disable_high_cardinality_metrics to "true". #6255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4769, I suggested that
disable_high_cardinality_metrics
default tofalse
for a few reasons:Unfortunately, it seems that those high cardinality metrics seem to really cause an understandable inconvenience for users. In the spirit of providing good defaults, it'd be best to exclude such metrics by default.
This will also simplify Static mode -> Flow converters, because high cardinality metrics are already disabled by default in Static mode.
I suspect that one day OTel Collector will have to also exclude these metrics by default. At the moment it's not a huge issue for the Collector, because you'd have to have a
telemetry.useOtelForInternalMetrics
feature gate enabled first.cc @glindstedt