Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Athena data connector #125

Merged
merged 24 commits into from
Nov 14, 2022
Merged

Athena data connector #125

merged 24 commits into from
Nov 14, 2022

Conversation

hwandersman
Copy link
Collaborator

@hwandersman hwandersman commented Nov 11, 2022

Review:
These diffs are more consumable to review:

Overview:

We built a new feature to enable customers to view static data from an Amazon Athena data connector. Customers will use the GetPropertyValue API to select two additional parameters propertyNames and tabularPropertyGroup .

Updated the GoLang backend to support the new parameters in GetPropertyValue, and the JS frontend to allow customers to select these parameters in the Grafana Query Editor.

Requirements:

UI Plugin

New flow for the GetPropertyValue query:

  1. Customer selects “Get Property Value”
    1. QueryEditor shows “Entity” selector
  2. Customer selects entity
    1. QueryEditor shows “Component Name” selector
  3. Customer selects component
    1. QueryEditor looks at the componentType of the component. If propertyGroups is in the componentType definition then show a “PropertyGroup” selector.
  4. Customer selects propertyGroup
    1. QueryEditor shows “Selected Properties” selector, “Filter” selector list, and “OrderBy” selector list
    2. “Selected Properties” will only show the properties that are listed in the selected propertyGroup

image

divya-sea and others added 23 commits November 1, 2022 14:05
* upgrade grafana deps

* upgrade grafana deps

* upgrade loa

* a few more updates
@CLAassistant
Copy link

CLAassistant commented Nov 11, 2022

CLA assistant check
All committers have signed the CLA.

@MO-Elmu MO-Elmu self-requested a review November 12, 2022 01:29
Copy link
Collaborator

@MO-Elmu MO-Elmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any issues will deal with them in the release branch after the merge.

@hwandersman hwandersman merged commit 84cbcd2 into 11172022_Release Nov 14, 2022
@mukeshsahay mukeshsahay deleted the athena-grafana branch January 24, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants