Skip to content

Commit

Permalink
AppPageCtrl: Fix digest issue with app page initialisation (#21847)
Browse files Browse the repository at this point in the history
  • Loading branch information
dprokop committed Jan 30, 2020
1 parent c425a83 commit 050d902
Showing 1 changed file with 11 additions and 8 deletions.
19 changes: 11 additions & 8 deletions public/app/features/plugins/plugin_page_ctrl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { PluginMeta } from '@grafana/data';
import { NavModelSrv } from 'app/core/core';
import { GrafanaRootScope } from 'app/routes/GrafanaCtrl';
import { AppEvents } from '@grafana/data';
import { promiseToDigest } from '../../core/utils/promiseToDigest';

export class AppPageCtrl {
page: any;
Expand All @@ -17,14 +18,16 @@ export class AppPageCtrl {
constructor(private $routeParams: any, private $rootScope: GrafanaRootScope, private navModelSrv: NavModelSrv) {
this.pluginId = $routeParams.pluginId;

Promise.resolve(getPluginSettings(this.pluginId))
.then(settings => {
this.initPage(settings);
})
.catch(err => {
this.$rootScope.appEvent(AppEvents.alertError, ['Unknown Plugin']);
this.navModel = this.navModelSrv.getNotFoundNav();
});
promiseToDigest($rootScope)(
Promise.resolve(getPluginSettings(this.pluginId))
.then(settings => {
this.initPage(settings);
})
.catch(err => {
this.$rootScope.appEvent(AppEvents.alertError, ['Unknown Plugin']);
this.navModel = this.navModelSrv.getNotFoundNav();
})
);
}

initPage(app: PluginMeta) {
Expand Down

0 comments on commit 050d902

Please sign in to comment.