Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: Fix routing in app plugin pages #21847

Merged
merged 1 commit into from Jan 30, 2020
Merged

Plugins: Fix routing in app plugin pages #21847

merged 1 commit into from Jan 30, 2020

Conversation

dprokop
Copy link
Member

@dprokop dprokop commented Jan 30, 2020 •
edited

Fixes #21842
Fixes raintank/worldping-app#233

Yet another digest issue :(

@dprokop dprokop added this to the 6.6.1 milestone Jan 30, 2020
@dprokop dprokop self-assigned this Jan 30, 2020
@dprokop dprokop added this to In Review in Frontend Platform Backlog via automation Jan 30, 2020
hugohaggmark
hugohaggmark approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@hugohaggmark hugohaggmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marefr
Copy link
Member

marefr commented Jan 30, 2020

Gonna test it to verify issues I reported have been solved

marefr
marefr approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! LGTM

@dprokop dprokop merged commit 050d902 into master Jan 30, 2020
Frontend Platform Backlog automation moved this from In Review to Done Jan 30, 2020
@dprokop dprokop deleted the fix-21842 branch January 30, 2020 12:47
@marefr marefr changed the title AppPageCtrl: Fix digest issue with app page initialisation Plugins: Fix routing in app plugin pages Feb 4, 2020
alexanderzobnin pushed a commit that referenced this pull request Feb 5, 2020
@dprokop @alexanderzobnin
AppPageCtrl: Fix digest issue with app page initialisation (#21847)
73a1369 
(cherry picked from commit 050d902)
alexanderzobnin pushed a commit that referenced this pull request Feb 6, 2020
@dprokop @alexanderzobnin
AppPageCtrl: Fix digest issue with app page initialisation (#21847)
9dd964f 
(cherry picked from commit 050d902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugohaggmark hugohaggmark hugohaggmark approved these changes

@marefr marefr marefr approved these changes

Assignees

@dprokop dprokop

Labels
add to changelog area/frontend type/bug
Projects
None yet
Milestone
6.6.1
4 participants
@dprokop @marefr @hugohaggmark @alexanderzobnin