Bug/Feature ? Grafana super admin can't be also admin of orgs

[darkweaver87]

Hello,

I'm using grafana 5.3.1 on debian stretch with ldap feature. I would like all my grafana super admins be also admins (a.k.a. role "Admin") of orgs.
So I have one AD group and reading at

grafana/pkg/login/ldap.go

Line 188 in f2833bf

extUser.IsGrafanaAdmin = group.IsGrafanaAdmin

if I set only one Admin role on this group, it will not benefit of being super admin.

Configuration to reproduce:

[[servers.group_mappings]]
group_dn = "CN=Grafana_Admins,OU=GRAFANA,OU=APPLICATIONS,DC=xxx,DC=xx"
org_role = "Admin"
grafana_admin = true

[[servers.group_mappings]]
group_dn = "CN=Grafana_Admins,OU=GRAFANA,OU=APPLICATIONS,DC=xxx,DC=xx"
org_role = "Admin"
org_id = 1

[[servers.group_mappings]]
group_dn = "CN=Grafana_Admins,OU=GRAFANA,OU=APPLICATIONS,DC=xxx,DC=xx"
org_role = "Admin"
org_id = 2

So it's an open question: bug or feature ?

[torkelo]

I guess that line should be

 extUser.IsGrafanaAdmin = extUser.IsGrafanaAdmin || group.IsGrafanaAdmin 

[darkweaver87]

Thanks for your feedback. My colleague and I are working on it :-)