Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Influxdb: Deprecate database field and move to jsonData #59115

Closed
gtk-grafana opened this issue Nov 22, 2022 · 2 comments · Fixed by #62308
Closed

Influxdb: Deprecate database field and move to jsonData #59115

gtk-grafana opened this issue Nov 22, 2022 · 2 comments · Fixed by #62308
Assignees
Labels
datasource/InfluxDB needs research for internal issues needing more research prio/low It's a good idea, but not scheduled for any release

Comments

@gtk-grafana
Copy link
Contributor

Following the plan laid out in #59098, and mentioned in #58647 (comment), we should migrate the database field into the jsonData, as the database field is deprecated in #58647.

Need to maintain backwards compatibility for initial release, and create a plan for eventual complete deprecation of the old field.

@gtk-grafana
Copy link
Contributor Author

@gabor What is the impact of releasing/not releasing this?

@gtk-grafana gtk-grafana added the needs research for internal issues needing more research label Jan 17, 2023
@gabor
Copy link
Contributor

gabor commented Jan 18, 2023

@gtk-grafana i don't think there is any short-term impact.

the current behavior of (influxdb&elastic) has been deprecated. it will work fine until grafana-core completely removes support for this. i mean, until they remove these lines: https://github.com/grafana/grafana/blob/main/pkg/api/frontendsettings.go#L323-L324

whether that will be ever removed, i don't know, my guess is that it won't be removed for some time, maybe @marefr has a better estimate.

still, i think it's a good idea to start migrating users to the "better" approach (i mean, doing the step1 from #59098).

i hope this explains the question, if not, ping me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource/InfluxDB needs research for internal issues needing more research prio/low It's a good idea, but not scheduled for any release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants