Datasource settings: Add deprecation notice for database field #58647
Conversation
zoltanbedi
requested review from
joshhunt,
ashharrison90,
leventebalogh,
mdvictor,
supilee,
wbrowne and
marefr
and removed request for
a team
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/41869 |
| @@ -558,6 +558,10 @@ export interface DataSourceSettings<T extends DataSourceJsonData = DataSourceJso | |||
| access: string; | |||
| url: string; | |||
| user: string; | |||
| /** | |||
| * @deprecated -- use jsonData to store information related to database. | |||
| * This field should only be used by Elasticsearch and Influxdb. | |||
There was a problem hiding this comment.
Sorry if it was asked somewhere else already, but are we planning to remove the use of this from Elasticsearch and Influxdb as well?
There was a problem hiding this comment.
Sorry but I don't know anything about them. Maybe @grafana/observability-logs can answer?
There was a problem hiding this comment.
we'd like to remove the use of this from Elasticsearch, but there's nothing planned yet (i created a github-issue to track this at #59098)
There was a problem hiding this comment.
regarding Influxdb, pinging @grafana/observability-metrics 😄
There was a problem hiding this comment.
I don't know of any plan to deprecate this, but it doesn't look like a huge lift to follow the plan laid out in the issue Gabor created above. I created an issue here #59115, so we don't loose track of this request.
|
This pull request was removed from the 9.3.0-beta1 milestone because 9.3.0-beta1 is currently being released. |
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42801 |
|
This pull request was removed from the 9.3.0 milestone because 9.3.0 is currently being released. |
This PR adds deprecation notice for the database field to let others know that we are migrating away from that field and instead should use the JSONData field for database related settings.
This is also based on our conversation with @marefr in slack. https://raintank-corp.slack.com/archives/C01C4K8DETW/p1668075734953779
Related to grafana/grafana-plugin-sdk-go#555