-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrumentation: Add support for instrumenting database queries #66022
Conversation
10494b0
to
f9a3a88
Compare
ping @papagian :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry I missed the ping!
Need to update the docs and remove the feature toggle as well
Signed-off-by: bergquist <carl.bergquist@gmail.com>
Signed-off-by: bergquist <carl.bergquist@gmail.com>
Signed-off-by: bergquist <carl.bergquist@gmail.com>
Signed-off-by: bergquist <carl.bergquist@gmail.com>
5dcfce7
to
5253dec
Compare
Signed-off-by: bergquist <carl.bergquist@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small docs suggestion, approved. Thank you for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
Signed-off-by: bergquist <carl.bergquist@gmail.com> Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
This feature toggle was added in #29662 and forgotten. It's about time we make it a grafana ini setting instead of a feature toggle :)
Closes #65989