Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] HELO string configurable in SMTP client #9319

Closed
thz opened this issue Sep 21, 2017 · 1 comment
Closed

[Feature request] HELO string configurable in SMTP client #9319

thz opened this issue Sep 21, 2017 · 1 comment
Labels
type/feature-request
Milestone
4.6.0-beta1

Comments

@thz
Copy link
Contributor

thz commented Sep 21, 2017

Scope:

  • SMTP client functionality for sending out emails.
  • In SMTP helo domain name #7223 the HELO string was changed to the name of the instance.

Situation:
We use an SMTP-relay from a provider and we need to set HELO name to a domain we have with them. That domain is not the same as the hostname grafana is running on.

For that reason the InstanceName as HELO name does not work for us.

Proposal:
As initially proposed in #7223 : a config option for setting the HELO name.

Would a PR adding an option to override the HELO name have any chance for acceptance?
@bergquist
Copy link
Contributor

@thz yes it would.

@thz thz mentioned this issue Sep 23, 2017
Merged
bergquist added a commit that referenced this issue Sep 24, 2017
@bergquist
changelog: add note ablout closing #9319
dd7f42b
@thz thz closed this as completed Sep 24, 2017
ryantxu added a commit to NatelEnergy/grafana that referenced this issue Sep 25, 2017
@ryantxu
Merge remote-tracking branch 'grafana/master'
00ad8e7 
* grafana/master:
  prom_docker: give targets correct job name
  testdata: add bucket scenarios for heatmap
  dev-docker: add grafana as target
  changelog: add note ablout closing grafana#9319
  introduce smtp config option for EHLO identity
  changelog: note about closing grafana#9250
  go fmt
  docs: update docs
  allow ssl renegotiation for datasources
@bergquist bergquist added this to the 4.6 milestone Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature-request
Projects
None yet
Milestone
4.6.0-beta1
Development

No branches or pull requests
3 participants
@torkelo @bergquist @thz