Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to superscript and /(per) #11896

Closed
wants to merge 2 commits into from
Closed

Change to superscript and /(per) #11896

wants to merge 2 commits into from

Conversation

flopp999
Copy link
Contributor

@flopp999 flopp999 commented May 9, 2018

@daniellee
Copy link
Contributor

I haven't tested this yet but it looks like there are a lot of breaking changes. Existing dashboards with those units would break?

If that is the case, then we can't merge this. Maybe you could explain a bit more about what you are trying to fix exactly?

@marefr
Copy link
Member

marefr commented May 15, 2018

As long as the key of the unit aren't changed it should not be a breaking change

torkelo
torkelo requested changes May 24, 2018
View reviewed changes
Copy link
Member

@torkelo torkelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests needs to updated and maybe new tests added

@flopp999 flopp999 changed the title Patch 6 Change to superscript and /(per) May 25, 2018
@marefr
Copy link
Member

marefr commented Jun 14, 2018

@flopp999 please rebase on master and fix failing tests for us to be able to review this further

@marefr marefr self-assigned this Jun 14, 2018
@flopp999
Copy link
Contributor Author

You can close this PR and I will open a new.

@flopp999 flopp999 closed this Jun 14, 2018
@flopp999 flopp999 deleted the patch-6 branch March 20, 2020 17:26
@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torkelo torkelo torkelo requested changes

Assignees

@marefr marefr

Labels
pr/changes-needed pr/external This PR is from external contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@flopp999 @daniellee @marefr @torkelo @ying-jeanne