Support timeFilter in query templating for InfluxDB #12598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
requested changes
Jul 13, 2018
|
Of course, I'll do that later this week
fre. 13. jul. 2018 21.11 skrev Torkel Ödegaard <notifications@github.com>:
… ***@***.**** requested changes on this pull request.
a unit test for this would be good.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12598 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWPf7DFMbXOmNM30KOJSbam1BE0W5ciks5uGPD4gaJpZM4VOvjx>
.
|
After support for queries in template variables was added to InfluxDB, it can be necessary to added dymanic time constraints. This can now be done changing the variable refresh to "On Time Range Changed" for InfluxDB
kichristensen
force-pushed
the
TimeRangeVariables
branch
from
aada60a
to
dd81f43
Compare
|
@torkelo I've now added a unit test for this |
|
Ahh timezone issues :( I'll fix it |
|
@torkelo The test should have been fixed now |
torkelo
approved these changes
Aug 2, 2018
|
@kichristensen you'll need to sign our Contributor License Agreement (CLA) in order for us to merge this. |
|
@marefr Done |
|
Thank you for contributing to Grafana! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After support for queries in template variables was added to InfluxDB, it can be necessary to added dymanic time constraints. This can now be done changing the variable refresh to "On Time Range Changed" for InfluxDB