Explore: typeahead and render performance improvements #13491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is best looked at on per-commit basis. I'll rebase once the review is done. |
|
Cool, hard to review it but looks good :) Can't really interpret the screenshots, looks like render duration went from 12ms to 14ms :) |
- Lower debounce - refactor suggestion selection - make Portal pure - use prev suggestions object if suggestions are the same
- remove `edited` property of query objects - query object semantics changes to be initial values only - resetting or externally modifying a query is done via giving it a new react key, which replaces the row completely - query changes while typing are sent up to Explore to be saved in a local property that is not part of the component state (prevent control circle) - all Explore functions using the queries must access the local property for current values
davkal
force-pushed
the
davkal/explore-perf
branch
from
964dab9
to
bdae399
Compare
Observability (deprecated, use Observability Squad)
automation
moved this from In progress
to Done
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements to speed up the query UX:
Before: lots of components needed to render when typing
After: fewer components need to render, and a lot fewer commits (flushing react tree to DOM)