Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore: typeahead and render performance improvements #13491

Merged
merged 4 commits into from Oct 4, 2018
Merged

Explore: typeahead and render performance improvements #13491

merged 4 commits into from Oct 4, 2018

Commits on Oct 4, 2018

  1. Dont rebuild datasource options on each render

    @davkal
    davkal committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    9914071 View commit details
    Browse the repository at this point in the history

  2. Perf on query field and typeahead 

    - Lower debounce
- refactor suggestion selection
- make Portal pure
- use prev suggestions object if suggestions are the same
    @davkal
    davkal committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    538ea11 View commit details
    Browse the repository at this point in the history

  3. Avoid new metrics options being passed selector, made PromField pure

    @davkal
    davkal committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    dc4b0cf View commit details
    Browse the repository at this point in the history

  4. Prevent Explore from updating when typing query 

    - remove `edited` property of query objects
- query object semantics changes to be initial values only
- resetting or externally modifying a query is done via giving it a new
  react key, which replaces the row completely
- query changes while typing are sent up to Explore to be saved in a
  local property that is not part of the component state (prevent
  control circle)
- all Explore functions using the queries must access the local property
  for current values
    @davkal
    davkal committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    bdae399 View commit details
    Browse the repository at this point in the history