Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AWS/Neptune Cloudwatch AWS #15214

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

tcpatterson
Copy link
Contributor

Resolves #14231

screen shot 2019-02-03 at 4 36 43 pm

Should I also knock out #14233 as part of this PR, or open a new one?

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2019

CLA assistant check
All committers have signed the CLA.

@marefr marefr self-requested a review February 4, 2019 10:04
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good based on dimensions and metrics

@marefr marefr merged commit 7436723 into grafana:master Feb 4, 2019
@marefr marefr added this to the 6.0-beta2 milestone Feb 4, 2019
@marefr
Copy link
Member

marefr commented Feb 4, 2019

Thank you for contributing to Grafana!

Please open a new PR for the other referneced issue.

@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for AWS/Neptune Cloudwatch AWS
4 participants