Explore: Move back / forward with browser buttons now works #16150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugohaggmark
changed the title
davkal
approved these changes
Mar 22, 2019
There was a problem hiding this comment.
LGTM
Works really well, and this is a well-written PR. Outstanding!
Small nit: Not happy with refresh..., as it's overlapping with browser refreshs. How about "save", or "persist"?
Found unrelated bug which will surface more when buttons are used: #16154
|
Just found out that back/forward doesn't work well with Graphite datasource #15862 |
|
+1 for update Great PR |
torkelo
approved these changes
Mar 22, 2019
dprokop
approved these changes
Mar 22, 2019
| thenThereAreNoDispatchedActions: () => ThunkWhen; | ||
| } | ||
|
|
||
| export const thunkTester = (initialState: any): ThunkGiven => { |
There was a problem hiding this comment.
Just wanted to say that using this testing API's you propose for redux is so much fun and easy!
hugohaggmark
changed the title
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Mar 22, 2019
* grafana/master: (30 commits) Makes it possible to navigate back/forward with browser buttons in Explore (grafana#16150) Moved DisplayValueOptions type back, grafana#16134 adding check for decimals add one more test Graphite: fixed variable quoting when variable value is nummeric, fixes grafana#2078 Minor refactoring of grafana#16127 Update provisioning.md Graphite: Fixed issue with using series ref and series by tag, fixes grafana#15237 move typings to types, Link license corrections removed option to not check strings drop one level of nesting cleanup and guess all columns Small license correction Enable sass theme change in Storybook replaced rems with pixels or variables adding test updating usages in singlestat Sorting imports adding function ...
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Mar 23, 2019
…-scroll-again * grafana/master: (499 commits) prevOptions should be optional moved migration hook to its own function Minor refactoring of stats picker / shared singlestat code Makes it possible to navigate back/forward with browser buttons in Explore (grafana#16150) Moved DisplayValueOptions type back, grafana#16134 adding check for decimals add one more test Graphite: fixed variable quoting when variable value is nummeric, fixes grafana#2078 Minor refactoring of grafana#16127 Update provisioning.md Graphite: Fixed issue with using series ref and series by tag, fixes grafana#15237 move typings to types, Link license corrections remove logging add stat picker to single stat removed option to not check strings drop one level of nesting cleanup and guess all columns Small license correction Enable sass theme change in Storybook ...
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Mar 23, 2019
…-srv * grafana/master: (153 commits) prevOptions should be optional moved migration hook to its own function Minor refactoring of stats picker / shared singlestat code Makes it possible to navigate back/forward with browser buttons in Explore (grafana#16150) Moved DisplayValueOptions type back, grafana#16134 adding check for decimals add one more test Graphite: fixed variable quoting when variable value is nummeric, fixes grafana#2078 Minor refactoring of grafana#16127 Update provisioning.md Graphite: Fixed issue with using series ref and series by tag, fixes grafana#15237 move typings to types, Link license corrections remove logging add stat picker to single stat removed option to not check strings drop one level of nesting cleanup and guess all columns Small license correction Enable sass theme change in Storybook ...
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Mar 24, 2019
* grafana/master: (272 commits) clarify notifications API docs remove processTimeSeries merge master don't use process timeseries rename stat to show in UI use display value in pie chart renamed float to flot prevOptions should be optional moved migration hook to its own function Minor refactoring of stats picker / shared singlestat code Makes it possible to navigate back/forward with browser buttons in Explore (grafana#16150) Moved DisplayValueOptions type back, grafana#16134 adding check for decimals add one more test Graphite: fixed variable quoting when variable value is nummeric, fixes grafana#2078 Minor refactoring of grafana#16127 Update provisioning.md Graphite: Fixed issue with using series ref and series by tag, fixes grafana#15237 move typings to types, Link license corrections ...
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Mar 24, 2019
* grafana/master: (342 commits) clarify notifications API docs remove processTimeSeries merge master don't use process timeseries rename stat to show in UI use display value in pie chart renamed float to flot prevOptions should be optional moved migration hook to its own function Minor refactoring of stats picker / shared singlestat code Makes it possible to navigate back/forward with browser buttons in Explore (grafana#16150) Moved DisplayValueOptions type back, grafana#16134 adding check for decimals add one more test Graphite: fixed variable quoting when variable value is nummeric, fixes grafana#2078 Minor refactoring of grafana#16127 Update provisioning.md Graphite: Fixed issue with using series ref and series by tag, fixes grafana#15237 move typings to types, Link license corrections ...
torkelo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes it possible to navigate backward and forward in browser using Explore.
Which issue(s) this PR fixes:
Fixes #14301
Special notes for your reviewer:
Checkout out the branch and try it out