Explore: Fixes so intervals are recalculated on run query #16510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
approved these changes
Apr 11, 2019
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Apr 11, 2019
* grafana/master: Update jwt regexp to include = (grafana#16521) Chore: docs fixes underscore formatting (grafana#16516) Fix: Pass missing maxDataPoints to query in Explore (grafana#16513) Fix: Recalculate intervals in Explore on run queries (grafana#16510) devenv: add elasticsearch v6 filebeat integration (grafana#16493) devenv: add worldmap panel panels for elasticsearch (grafana#16313)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Apr 12, 2019
…-srv * grafana/master: (59 commits) Chore: Remove implicit anys for DashboardModel and tests (grafana#16553) Pushover alert, support for different sound for OK (grafana#16525) Chore: Lowered implicit anys limit to 6816 CloudWatch: Fix template variable expand bug (grafana#16405) CloudWatch: fix color order (grafana#16408) Plugins: Unifying alpha state & options for all plugins (grafana#16530) Revert "Build: Upgrades to go 1.12.3 (grafana#16491)" (grafana#16544) Annotations: Annotation list style improvements (grafana#16541) QueryInspector: Now shows error responses (grafana#16514) Build: Upgrades to go 1.12.3 (grafana#16491) Build: Update master version number (grafana#16532) Elasticsearch: Format elasticsearch test dashboard json (grafana#16537) Update jwt regexp to include = (grafana#16521) Chore: docs fixes underscore formatting (grafana#16516) Fix: Pass missing maxDataPoints to query in Explore (grafana#16513) Fix: Recalculate intervals in Explore on run queries (grafana#16510) devenv: add elasticsearch v6 filebeat integration (grafana#16493) devenv: add worldmap panel panels for elasticsearch (grafana#16313) Plugins: Optionally preload some plugins during frontend app boot (grafana#15266) Panels: Add types for DataList and range (grafana#16500) ...
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Apr 14, 2019
* grafana/master: (63 commits) DirectInput: new alpha datasource that lets you enter data via CSV Plugins: expose getBackendSrv() to plugins (grafana#15268) DataPanel: Added built-in interval variables to scopedVars (grafana#16556) TestData: Add minInterval query option Chore: Remove implicit anys for DashboardModel and tests (grafana#16553) Pushover alert, support for different sound for OK (grafana#16525) Chore: Lowered implicit anys limit to 6816 CloudWatch: Fix template variable expand bug (grafana#16405) CloudWatch: fix color order (grafana#16408) Plugins: Unifying alpha state & options for all plugins (grafana#16530) Revert "Build: Upgrades to go 1.12.3 (grafana#16491)" (grafana#16544) Annotations: Annotation list style improvements (grafana#16541) QueryInspector: Now shows error responses (grafana#16514) Build: Upgrades to go 1.12.3 (grafana#16491) Build: Update master version number (grafana#16532) Elasticsearch: Format elasticsearch test dashboard json (grafana#16537) Update jwt regexp to include = (grafana#16521) Chore: docs fixes underscore formatting (grafana#16516) Fix: Pass missing maxDataPoints to query in Explore (grafana#16513) Fix: Recalculate intervals in Explore on run queries (grafana#16510) ...
dprokop
pushed a commit
that referenced
this pull request
Apr 16, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We only calculated intervals when we initialized Explore and on resize. This PR makes sure that we always recalculate intervals before running any query.
Which issue(s) this PR fixes:
Fixes: #16485
Special notes for your reviewer: