-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: a bit of spring cleaning #16710
Conversation
And enable "indent-error-flow" revive rule
And enable "error-strings" revive rule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the comment in server.go
Looks good otherwise.
pkg/cmd/grafana-server/server.go
Outdated
@@ -10,38 +10,36 @@ import ( | |||
"path/filepath" | |||
"strconv" | |||
"time" | |||
// self registering services |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, I use a plugin for vscode now that changes sorting of imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* grafana/master: docs: fix upgrade instructions Chore: Small improvements to grafana-cli (grafana#16670) Chore: Use x/xerrors instead of pkg/errors (grafana#16668) Chore: a bit of spring cleaning (grafana#16710)
…a-alt * grafana/master: Refactor: Make SelectOptionItem a generic type to enable select value typing (grafana#16718) docs: fix upgrade instructions Chore: Small improvements to grafana-cli (grafana#16670) Chore: Use x/xerrors instead of pkg/errors (grafana#16668) Chore: a bit of spring cleaning (grafana#16710) Fixes grafana#15863 (grafana#16684) Docs: Update notification services (grafana#16657) PanelQueryRunner: add datasource name to queries (grafana#16712)
…-scroll-again * grafana/master: Refactor: Make SelectOptionItem a generic type to enable select value typing (grafana#16718) docs: fix upgrade instructions Chore: Small improvements to grafana-cli (grafana#16670) Chore: Use x/xerrors instead of pkg/errors (grafana#16668) Chore: a bit of spring cleaning (grafana#16710) Fixes grafana#15863 (grafana#16684) Docs: Update notification services (grafana#16657) PanelQueryRunner: add datasource name to queries (grafana#16712) Chore: remove session storage references (grafana#16445) Dashboard: Minor settings UI Update (grafana#16669) Templating: Do not copy hide option (grafana#16696) Docs: Fix advanced variable formatting examples (grafana#16691) QueryEditors: pass PanelData and filtered PanelData to each editor (grafana#16692)
This pull re-enables some of the revive rules and fixes associated "errors" with it.
It seems some of it is subjective, so I would say not set on stone :)