Chore: a bit of spring cleaning #16710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And enable "indent-error-flow" revive rule
And enable "error-strings" revive rule
bergquist
reviewed
Apr 23, 2019
pkg/cmd/grafana-server/server.go
Outdated
| @@ -10,38 +10,36 @@ import ( | |||
| "path/filepath" | |||
| "strconv" | |||
| "time" | |||
| // self registering services | |||
There was a problem hiding this comment.
This comment can be removed
There was a problem hiding this comment.
Oh yeah, I use a plugin for vscode now that changes sorting of imports
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Apr 23, 2019
* grafana/master: docs: fix upgrade instructions Chore: Small improvements to grafana-cli (grafana#16670) Chore: Use x/xerrors instead of pkg/errors (grafana#16668) Chore: a bit of spring cleaning (grafana#16710)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Apr 23, 2019
…a-alt * grafana/master: Refactor: Make SelectOptionItem a generic type to enable select value typing (grafana#16718) docs: fix upgrade instructions Chore: Small improvements to grafana-cli (grafana#16670) Chore: Use x/xerrors instead of pkg/errors (grafana#16668) Chore: a bit of spring cleaning (grafana#16710) Fixes grafana#15863 (grafana#16684) Docs: Update notification services (grafana#16657) PanelQueryRunner: add datasource name to queries (grafana#16712)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Apr 24, 2019
…-scroll-again * grafana/master: Refactor: Make SelectOptionItem a generic type to enable select value typing (grafana#16718) docs: fix upgrade instructions Chore: Small improvements to grafana-cli (grafana#16670) Chore: Use x/xerrors instead of pkg/errors (grafana#16668) Chore: a bit of spring cleaning (grafana#16710) Fixes grafana#15863 (grafana#16684) Docs: Update notification services (grafana#16657) PanelQueryRunner: add datasource name to queries (grafana#16712) Chore: remove session storage references (grafana#16445) Dashboard: Minor settings UI Update (grafana#16669) Templating: Do not copy hide option (grafana#16696) Docs: Fix advanced variable formatting examples (grafana#16691) QueryEditors: pass PanelData and filtered PanelData to each editor (grafana#16692)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull re-enables some of the revive rules and fixes associated "errors" with it.
It seems some of it is subjective, so I would say not set on stone :)