Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: ReactPanelPlugin to VizPanelPlugin #16779

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Plugins: ReactPanelPlugin to VizPanelPlugin #16779

merged 2 commits into from
Apr 26, 2019

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented Apr 26, 2019

  • Rename ReactPanelPlugin to VizPanelPlugin
  • Rename expected export for react panels to just plugin to align it with data source plugins.

Fixes #16578
Fixes #16758

@dprokop
Copy link
Member

dprokop commented Apr 26, 2019 •
edited
Loading

Cool, but shouldn't it be VisPanelPlugin or explicitly VisualizationPanelPlugin? Not sure why it is Viz.

@torkelo
Copy link
Member Author

torkelo commented Apr 26, 2019

possibly, it's a bit verbose, but probably clearer to use the full term

@dprokop
Copy link
Member

dprokop commented Apr 26, 2019 •
edited
Loading

Agree, but we are verbose in DataSourcePlugin so I think it's fine. My biggest concern was the z instead of s in Vis. Details ;)

@torkelo
Copy link
Member Author

torkelo commented Apr 26, 2019

Maybe just VisualizationPlugin only? but that will trigger so much renaming for all the props and editor types that have Panel in then name. VisualizationPanelPlugin feels a bit repetitive. An alternative is just PanelPlugin for simple and short name

@dprokop
Copy link
Member

dprokop commented Apr 26, 2019

Actually PanelPlugin is a very good name 👍 Not every panel is a visualisation actually, but every visualisation panel is... well, panel ;)

@torkelo
Copy link
Member Author

torkelo commented Apr 26, 2019

Only downside with that name is that it conflicts with this type https://github.com/grafana/grafana/blob/master/public/app/types/plugins.ts#L3

that is already called that, it's an internal type that represents an installed available panel plugin

@ryantxu
Copy link
Member

ryantxu commented Apr 26, 2019

Can we change the existing PanelPlugin to PanelPluginMeta?

@torkelo
Copy link
Member Author

torkelo commented Apr 26, 2019

Renamed PanelPlugin to PanelPluginMeta (makes sense as it extends PluginMeta), and renamed VizPanelPlugin to just PanelPlugin.

@ryantxu
Copy link
Member

ryantxu commented Apr 26, 2019

Looks good -- I think this makes a lot more sense

@torkelo torkelo merged commit 060e97b into master Apr 26, 2019
@torkelo torkelo deleted the react-panel-to-viz branch April 26, 2019 17:16
ryantxu added a commit to ryantxu/grafana that referenced this pull request Apr 29, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into transforms
2080d9b 
* grafana/master:
  build: restore postgres integration tests (grafana#16801)
  docs: explain correct access control model of GCS buckets (grafana#16792)
  Chore: Fixed no implicit any Typescript errors (grafana#16799)
  Feature: introduce LdapActiveSyncEnabled setting (grafana#16787)
  Plugins: ReactPanelPlugin to VizPanelPlugin (grafana#16779)
  UX: Improve Grafana usage for smaller screens  (grafana#16783)
  ThresholdEditor: Minor style fix for smaller screens (grafana#16791)
  Build: Use isolated modules for ts-jest (grafana#16786)
  LDAP Refactoring to support syncronizing more than one user at a time. (grafana#16705)
  build: removes unused vendored files
  (fix/explore): remove vertical-align looks better for long logs (grafana#16736)
  Chore: bump jQuery to 3.4.0 in grafana/ui (grafana#16781)
  Devenv: Updated home dashboard and added new influxdb test dashboard
  Chore: Lowered implicit anys limit to 5946
  RefreshPicker: minor design update (grafana#16774)
  Streaming: support streaming and a javascript test datasource (grafana#16729)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Apr 29, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into min-max-field
88e33c1 
* grafana/master:
  build: restore postgres integration tests (grafana#16801)
  docs: explain correct access control model of GCS buckets (grafana#16792)
  Chore: Fixed no implicit any Typescript errors (grafana#16799)
  Feature: introduce LdapActiveSyncEnabled setting (grafana#16787)
  Plugins: ReactPanelPlugin to VizPanelPlugin (grafana#16779)
  UX: Improve Grafana usage for smaller screens  (grafana#16783)
  ThresholdEditor: Minor style fix for smaller screens (grafana#16791)
  Build: Use isolated modules for ts-jest (grafana#16786)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Apr 29, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into stream-mixed-query
2248f35 
* grafana/master:
  build: restore postgres integration tests (grafana#16801)
  docs: explain correct access control model of GCS buckets (grafana#16792)
  Chore: Fixed no implicit any Typescript errors (grafana#16799)
  Feature: introduce LdapActiveSyncEnabled setting (grafana#16787)
  Plugins: ReactPanelPlugin to VizPanelPlugin (grafana#16779)
  UX: Improve Grafana usage for smaller screens  (grafana#16783)
  ThresholdEditor: Minor style fix for smaller screens (grafana#16791)
  Build: Use isolated modules for ts-jest (grafana#16786)
  LDAP Refactoring to support syncronizing more than one user at a time. (grafana#16705)
  build: removes unused vendored files
  (fix/explore): remove vertical-align looks better for long logs (grafana#16736)
  Chore: bump jQuery to 3.4.0 in grafana/ui (grafana#16781)
  Devenv: Updated home dashboard and added new influxdb test dashboard
  Chore: Lowered implicit anys limit to 5946
  RefreshPicker: minor design update (grafana#16774)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Apr 29, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into useQueryRunner-in-…
b3942e4 
…MetricPanelCtrl

* grafana/master:
  build: restore postgres integration tests (grafana#16801)
  docs: explain correct access control model of GCS buckets (grafana#16792)
  Chore: Fixed no implicit any Typescript errors (grafana#16799)
  Feature: introduce LdapActiveSyncEnabled setting (grafana#16787)
  Plugins: ReactPanelPlugin to VizPanelPlugin (grafana#16779)
  UX: Improve Grafana usage for smaller screens  (grafana#16783)
  ThresholdEditor: Minor style fix for smaller screens (grafana#16791)
  Build: Use isolated modules for ts-jest (grafana#16786)
  LDAP Refactoring to support syncronizing more than one user at a time. (grafana#16705)
  build: removes unused vendored files
  (fix/explore): remove vertical-align looks better for long logs (grafana#16736)
  Chore: bump jQuery to 3.4.0 in grafana/ui (grafana#16781)
  Devenv: Updated home dashboard and added new influxdb test dashboard
  Chore: Lowered implicit anys limit to 5946
  RefreshPicker: minor design update (grafana#16774)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Apr 29, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into react-app-pages
5f63e3a 
* grafana/master:
  build: restore postgres integration tests (grafana#16801)
  docs: explain correct access control model of GCS buckets (grafana#16792)
  Chore: Fixed no implicit any Typescript errors (grafana#16799)
  Feature: introduce LdapActiveSyncEnabled setting (grafana#16787)
  Plugins: ReactPanelPlugin to VizPanelPlugin (grafana#16779)
  UX: Improve Grafana usage for smaller screens  (grafana#16783)
  ThresholdEditor: Minor style fix for smaller screens (grafana#16791)
  Build: Use isolated modules for ts-jest (grafana#16786)
  LDAP Refactoring to support syncronizing more than one user at a time. (grafana#16705)
  build: removes unused vendored files
  (fix/explore): remove vertical-align looks better for long logs (grafana#16736)
  Chore: bump jQuery to 3.4.0 in grafana/ui (grafana#16781)
  Devenv: Updated home dashboard and added new influxdb test dashboard
  Chore: Lowered implicit anys limit to 5946
  RefreshPicker: minor design update (grafana#16774)
@ryantxu ryantxu mentioned this pull request Apr 29, 2019
Merged
bergquist added a commit to vivtony00/grafana that referenced this pull request Apr 30, 2019
@bergquist
Merge branch 'master' into vivtony00-master
4dfd46a 
* master: (470 commits)
  removes gopkg.lock from root folder
  Explore: Support user timezone (grafana#16469)
  Plugins: rename vizPlugin to panelPlugin (grafana#16802)
  Plugins: move app/feature/plugin properties into PluginMeta (grafana#16809)
  Plugins: move PanelPluginMeta to grafana/ui (grafana#16804)
  Plugins: move datasource specific meta out of the main meta type (grafana#16803)
  updates changelog for 6.1.6
  Fix: Fetch histogram series from other api route (grafana#16768)
  phantomjs: set web-security to true
  Chore: Lowered implicit anys limit to 5668
  build: restore postgres integration tests (grafana#16801)
  docs: explain correct access control model of GCS buckets (grafana#16792)
  Chore: Fixed no implicit any Typescript errors (grafana#16799)
  Feature: introduce LdapActiveSyncEnabled setting (grafana#16787)
  Plugins: ReactPanelPlugin to VizPanelPlugin (grafana#16779)
  UX: Improve Grafana usage for smaller screens  (grafana#16783)
  ThresholdEditor: Minor style fix for smaller screens (grafana#16791)
  Build: Use isolated modules for ts-jest (grafana#16786)
  LDAP Refactoring to support syncronizing more than one user at a time. (grafana#16705)
  build: removes unused vendored files
  ...
ryantxu added a commit to ryantxu/grafana that referenced this pull request May 3, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into reuse-query2
fd52dc4 
* grafana/master:
  build: restore postgres integration tests (grafana#16801)
  docs: explain correct access control model of GCS buckets (grafana#16792)
  Chore: Fixed no implicit any Typescript errors (grafana#16799)
  Feature: introduce LdapActiveSyncEnabled setting (grafana#16787)
  Plugins: ReactPanelPlugin to VizPanelPlugin (grafana#16779)
  UX: Improve Grafana usage for smaller screens  (grafana#16783)
  ThresholdEditor: Minor style fix for smaller screens (grafana#16791)
  Build: Use isolated modules for ts-jest (grafana#16786)
  LDAP Refactoring to support syncronizing more than one user at a time. (grafana#16705)
  build: removes unused vendored files
  (fix/explore): remove vertical-align looks better for long logs (grafana#16736)
  Chore: bump jQuery to 3.4.0 in grafana/ui (grafana#16781)
  Devenv: Updated home dashboard and added new influxdb test dashboard
  Chore: Lowered implicit anys limit to 5946
  RefreshPicker: minor design update (grafana#16774)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react panel export from reactPanel to just plugin Consider renaming ReactPanelPlugin to VizPanelPlugin
3 participants
@torkelo @dprokop @ryantxu