Dashboard: Enable filtering dashboards in search by current folder #16790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
reviewed
Apr 28, 2019
There was a problem hiding this comment.
Great job!
- Missing cursor: pointer on the navbar-page-btn (due to change from a tag to div)
- There are different behavior when you click on dashboard name or folder name. Think both should behave the same it's a single "button". That is always open in folder context when in a folder.
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
May 2, 2019
* grafana/master: Datasources: add support for POST HTTP verb for InfluxDB (grafana#16690) Add pattern validation in configs (grafana#16837) Search: Enable filtering dashboards in search by current folder (grafana#16790) FormLabel: allow any rather than just a string for tooltip (grafana#16841)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
May 2, 2019
* grafana/master: Datasources: add support for POST HTTP verb for InfluxDB (grafana#16690) Add pattern validation in configs (grafana#16837) Search: Enable filtering dashboards in search by current folder (grafana#16790)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
May 3, 2019
* grafana/master: Chore: Lowered implicit anys limit to 5623 TestData: Add dashboards to testdata (grafana#16855) Input Datasource: convert from angular config to react ConfigEditor (grafana#16856) DataSources: minor typescript cleanups and comments (grafana#16860) TestDataDatasource: Add config editor (grafana#16861) App Plugins: support react pages and tabs (grafana#16586) Add Windows MSI generation to build process (grafana#16502) Datasources: add support for POST HTTP verb for InfluxDB (grafana#16690) Add pattern validation in configs (grafana#16837) Search: Enable filtering dashboards in search by current folder (grafana#16790)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
May 3, 2019
…MetricPanelCtrl * grafana/master: (24 commits) CSV: escape quotes in toCSV (grafana#16874) Dashboard: Lazy load out of view panels (grafana#15554) LDAP: Added reload endpoint for LDAP config (grafana#15470) PluginsList: Removed icons and updated snapshots (grafana#16872) Panels: Fixed issue with panel type change and data updates (grafana#16871) Chore: fix modes for non-executable files (grafana#16864) DataSourceSettings: Minor fix for uncontrolled input (grafana#16863) Chore: Lowered implicit anys limit to 5623 TestData: Add dashboards to testdata (grafana#16855) Input Datasource: convert from angular config to react ConfigEditor (grafana#16856) DataSources: minor typescript cleanups and comments (grafana#16860) TestDataDatasource: Add config editor (grafana#16861) App Plugins: support react pages and tabs (grafana#16586) Add Windows MSI generation to build process (grafana#16502) Datasources: add support for POST HTTP verb for InfluxDB (grafana#16690) Add pattern validation in configs (grafana#16837) Search: Enable filtering dashboards in search by current folder (grafana#16790) FormLabel: allow any rather than just a string for tooltip (grafana#16841) prometheus: fix regression after adding support for tracing headers (grafana#16829) area/circleci: Speed up circleci build process for branches and pr (grafana#16778) ...
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
May 3, 2019
* grafana/master: (44 commits) CSV: escape quotes in toCSV (grafana#16874) Dashboard: Lazy load out of view panels (grafana#15554) LDAP: Added reload endpoint for LDAP config (grafana#15470) PluginsList: Removed icons and updated snapshots (grafana#16872) Panels: Fixed issue with panel type change and data updates (grafana#16871) Chore: fix modes for non-executable files (grafana#16864) DataSourceSettings: Minor fix for uncontrolled input (grafana#16863) Chore: Lowered implicit anys limit to 5623 TestData: Add dashboards to testdata (grafana#16855) Input Datasource: convert from angular config to react ConfigEditor (grafana#16856) DataSources: minor typescript cleanups and comments (grafana#16860) TestDataDatasource: Add config editor (grafana#16861) App Plugins: support react pages and tabs (grafana#16586) Add Windows MSI generation to build process (grafana#16502) Datasources: add support for POST HTTP verb for InfluxDB (grafana#16690) Add pattern validation in configs (grafana#16837) Search: Enable filtering dashboards in search by current folder (grafana#16790) FormLabel: allow any rather than just a string for tooltip (grafana#16841) prometheus: fix regression after adding support for tracing headers (grafana#16829) area/circleci: Speed up circleci build process for branches and pr (grafana#16778) ...
marefr
changed the title
|
While this is a really cool feature, it would be great if it would still show a list of other categories as well. Perhaps a nice option would be to have a separate action for clicking the folder vs. clicking the dashboard? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First proposal to solve #14739
It assumes introducing simple query lang to the search (similar to Gmail's) https://github.com/nepsilon/search-query-parser
For now it naively supports
folder:currentkeyword only, but I want to expand on this idea a little bit more when working on Search -> React migration.The
folderkeyword results in search results from within specified folders. In longer run I would like to be able to addfolder:[current|folder_name|folder_id]resolving. I assume (not sure if there is a real need for that) but we could in the same manner search for specific tags and enable shareable search queries. But first we have to make sure this is something worth exploring.@torkelo I don't want to put too much effort into this ATM, would love to focus on general search rewrite and deliver MVP here only. WDYT?
FYI @Ijin08
TODO: