Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure: Azure Monitor and Log Analytics converted and separated into components #18259

Merged
merged 15 commits into from
Aug 19, 2019
Merged

Azure: Azure Monitor and Log Analytics converted and separated into components #18259

merged 15 commits into from
Aug 19, 2019

Conversation

shavonn
Copy link
Contributor

@shavonn shavonn commented Jul 24, 2019

No description provided.

@shavonn shavonn self-assigned this Jul 24, 2019
daniellee
daniellee previously requested changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@daniellee daniellee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding a new datasource, the Save and test returns the error:

Nothing configured. At least one of the API's must be configured.

Think is due to length being an undefined property for the subscription object:

https://github.com/grafana/grafana/blob/17880-reactify-and-consolidate-azure-creds/public/app/plugins/datasource/grafana-azure-monitor-datasource/azure_monitor/azure_monitor_datasource.ts#L47

Also, shouldn't the 'Same details as Azure Monitor API` option for Azure Logs be true per default?

briangann
briangann approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@briangann briangann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, is now working from both filling out a new datasource and with a provisioning file.

Let's get this merged!

@shavonn shavonn marked this pull request as ready for review August 1, 2019 18:13
@shavonn shavonn requested a review from daniellee August 1, 2019 18:13
@shavonn
Copy link
Contributor Author

shavonn commented Aug 1, 2019

When adding a new datasource, the Save and test returns the error:

Nothing configured. At least one of the API's must be configured.

Think is due to length being an undefined property for the subscription object:

https://github.com/grafana/grafana/blob/17880-reactify-and-consolidate-azure-creds/public/app/plugins/datasource/grafana-azure-monitor-datasource/azure_monitor/azure_monitor_datasource.ts#L47

Also, shouldn't the 'Same details as Azure Monitor API` option for Azure Logs be true per default?

It is.

@briangann briangann added this to the 6.3.0 milestone Aug 2, 2019
@briangann briangann dismissed daniellee’s stale review August 2, 2019 13:28

these bugs were fixed

@shavonn shavonn requested a review from xlson August 2, 2019 13:41
@shavonn shavonn requested a review from briangann August 5, 2019 14:31
@xlson xlson removed this from the 6.3.0 milestone Aug 6, 2019
@xlson xlson added this to the 6.4 milestone Aug 6, 2019
@xlson xlson removed their request for review August 6, 2019 06:43
@daniellee daniellee merged commit f22aaa5 into master Aug 19, 2019
@daniellee daniellee deleted the 17880-reactify-and-consolidate-azure-creds branch August 19, 2019 21:35
ryantxu added a commit to ryantxu/grafana that referenced this pull request Aug 19, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into jwt
787cafa 
* grafana/master: (202 commits)
  Azure Monitor and Log Analytics converted and separated into components (grafana#18259)
  Rewrite user profile edit to react (grafana#17917)
  Docs: remove codecov badge (grafana#18623)
  Prometheus: Prevents panel editor crash when switching to Prometheus datasource (grafana#18616)
  Chore: Rename Popper to Popover (grafana#18543)
  SingleStat: add a gauge migration call to action button in the editor (grafana#18604)
  Build: update revive dependency (grafana#18585)
  LDAP: multildap + ldap integration (grafana#18588)
  Docker: switch docker image to alpine base with phantomjs support (grafana#18468)
  Backend: Adds support for HTTP/2 (grafana#18358)
  Explore: Fixes error when switching from prometheus to loki data sources (grafana#18599)
  TimePicker: Set time to to 23:59:59 when setting To time using calendar (grafana#18595)
  Prometheus: Return labels in query results (grafana#18535)
  Docs: Update changelog and docs for annotation region change (grafana#18593)
  Refactor: move KeyValue and deprecation warning to @grafana/data (grafana#18582)
  Annotations: use a single row to represent a region (grafana#17673)
  Docs: Update upgrading guide (grafana#18547)
  Docs: Adds tests requirement to bugs checklist (grafana#18576)
  DataFrame: convert from row based to a columnar value format (grafana#18391)
  Packages: Temporarily skip canary releases if packages build fail (grafana#18577)
  ...
ryantxu added a commit to ryantxu/grafana that referenced this pull request Aug 20, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into single-stat-data-f…
190908e 
…rame

* grafana/master:
  MSI: new long file names are causing error building MSI (grafana#18646)
  Auth: change the error HTTP status codes (grafana#18584)
  Refactor: EmptyListCTA (grafana#18516)
  Build: Upgrade to go 1.12.9 (grafana#18638)
  Chore: Revert React 16.9.0 bump (grafana#18634)
  Azure Monitor and Log Analytics converted and separated into components (grafana#18259)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Aug 21, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into transforms
f6be164 
* grafana/master:
  SingleStat: use DataFrame results rather than TimeSeries/TableData (grafana#18580)
  TestData: attach labels to series results (grafana#18653)
  Singlestat: Disable new singlestat gauge usage (grafana#18610)
  Explore: Fixes query field layout in splitted view for Safari browsers (grafana#18654)
  MSI: new long file names are causing error building MSI (grafana#18646)
  Auth: change the error HTTP status codes (grafana#18584)
  Refactor: EmptyListCTA (grafana#18516)
  Build: Upgrade to go 1.12.9 (grafana#18638)
  Chore: Revert React 16.9.0 bump (grafana#18634)
  Azure Monitor and Log Analytics converted and separated into components (grafana#18259)
  Rewrite user profile edit to react (grafana#17917)
  Docs: remove codecov badge (grafana#18623)
  Prometheus: Prevents panel editor crash when switching to Prometheus datasource (grafana#18616)
  Chore: Rename Popper to Popover (grafana#18543)
  SingleStat: add a gauge migration call to action button in the editor (grafana#18604)
  Build: update revive dependency (grafana#18585)
  LDAP: multildap + ldap integration (grafana#18588)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Aug 21, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into stream-mixed-query
4cf9bc4 
* grafana/master:
  SingleStat: use DataFrame results rather than TimeSeries/TableData (grafana#18580)
  TestData: attach labels to series results (grafana#18653)
  Singlestat: Disable new singlestat gauge usage (grafana#18610)
  Explore: Fixes query field layout in splitted view for Safari browsers (grafana#18654)
  MSI: new long file names are causing error building MSI (grafana#18646)
  Auth: change the error HTTP status codes (grafana#18584)
  Refactor: EmptyListCTA (grafana#18516)
  Build: Upgrade to go 1.12.9 (grafana#18638)
  Chore: Revert React 16.9.0 bump (grafana#18634)
  Azure Monitor and Log Analytics converted and separated into components (grafana#18259)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Aug 21, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into reuse-query2
495b449 
* grafana/master:
  SingleStat: use DataFrame results rather than TimeSeries/TableData (grafana#18580)
  TestData: attach labels to series results (grafana#18653)
  Singlestat: Disable new singlestat gauge usage (grafana#18610)
  Explore: Fixes query field layout in splitted view for Safari browsers (grafana#18654)
  MSI: new long file names are causing error building MSI (grafana#18646)
  Auth: change the error HTTP status codes (grafana#18584)
  Refactor: EmptyListCTA (grafana#18516)
  Build: Upgrade to go 1.12.9 (grafana#18638)
  Chore: Revert React 16.9.0 bump (grafana#18634)
  Azure Monitor and Log Analytics converted and separated into components (grafana#18259)
  Rewrite user profile edit to react (grafana#17917)
  Docs: remove codecov badge (grafana#18623)
  Prometheus: Prevents panel editor crash when switching to Prometheus datasource (grafana#18616)
  Chore: Rename Popper to Popover (grafana#18543)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Aug 21, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into clone-reference-panel
b439cfb 
* grafana/master:
  SingleStat: use DataFrame results rather than TimeSeries/TableData (grafana#18580)
  TestData: attach labels to series results (grafana#18653)
  Singlestat: Disable new singlestat gauge usage (grafana#18610)
  Explore: Fixes query field layout in splitted view for Safari browsers (grafana#18654)
  MSI: new long file names are causing error building MSI (grafana#18646)
  Auth: change the error HTTP status codes (grafana#18584)
  Refactor: EmptyListCTA (grafana#18516)
  Build: Upgrade to go 1.12.9 (grafana#18638)
  Chore: Revert React 16.9.0 bump (grafana#18634)
  Azure Monitor and Log Analytics converted and separated into components (grafana#18259)
  Rewrite user profile edit to react (grafana#17917)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Aug 23, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into datalink-on-field
b1a6e48 
* grafana/master:
  SingleStat2: save options to defaults not override (grafana#18666)
  Packages: Fix path import from grafana/data (grafana#18667)
  SingleStat: use DataFrame results rather than TimeSeries/TableData (grafana#18580)
  TestData: attach labels to series results (grafana#18653)
  Singlestat: Disable new singlestat gauge usage (grafana#18610)
  Explore: Fixes query field layout in splitted view for Safari browsers (grafana#18654)
  MSI: new long file names are causing error building MSI (grafana#18646)
  Auth: change the error HTTP status codes (grafana#18584)
  Refactor: EmptyListCTA (grafana#18516)
  Build: Upgrade to go 1.12.9 (grafana#18638)
  Chore: Revert React 16.9.0 bump (grafana#18634)
  Azure Monitor and Log Analytics converted and separated into components (grafana#18259)
  Rewrite user profile edit to react (grafana#17917)
  Docs: remove codecov badge (grafana#18623)
  Prometheus: Prevents panel editor crash when switching to Prometheus datasource (grafana#18616)
  Chore: Rename Popper to Popover (grafana#18543)
  SingleStat: add a gauge migration call to action button in the editor (grafana#18604)
  Build: update revive dependency (grafana#18585)
  LDAP: multildap + ldap integration (grafana#18588)
@daniellee daniellee mentioned this pull request Sep 9, 2019
Closed
@torkelo torkelo changed the title Azure Monitor and Log Analytics converted and separated into components Azure: Azure Monitor and Log Analytics converted and separated into components Sep 17, 2019
@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellee daniellee daniellee approved these changes

@briangann briangann Awaiting requested review from briangann

Assignees

@shavonn shavonn

Labels
area/datasource/frontend datasource/Azure Azure Monitor Datasource pr/external This PR is from external contributor prio/support-subscription type/feature-request
Projects
None yet
Milestone
6.4.0-beta1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@shavonn @daniellee @briangann @torkelo @xlson @ying-jeanne