Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages: Temporarily skip canary releases if packages build fail #18577

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

dprokop
Copy link
Member

@dprokop dprokop commented Aug 15, 2019

@ryan regarding grafana-ui build failing on master. Did some debugging and apparently merge of #18549 introduced this regression (as proven checked here #18574). Could find a solution nor reproduce yet.

@kaydelaney is investigating that, we don't have a solution yet. For now, to unblock master builds, I suggest merging this and simply skip canary releases if packages build fails.

This should be reverted as soon as we find the underlying problem!

@dprokop dprokop requested a review from ryantxu August 15, 2019 14:28
Copy link
Member

@ryantxu ryantxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryantxu ryantxu merged commit 350b9a9 into master Aug 15, 2019
ryantxu added a commit to ryantxu/grafana that referenced this pull request Aug 15, 2019
* grafana/master:
  Packages: Temporarily skip canary releases if packages build fail (grafana#18577)
  Update latest.json to latest stable version (grafana#18575)
  Docs: Update changelog for v6.3.3 (grafana#18569)
  Graph: Fixed issue clicking on series line icon (grafana#18563)
  grafana/toolkit: Unpublish previous "next" version when releasing a new one (grafana#18552)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Aug 15, 2019
* grafana/master:
  DataFrame: convert from row based to a columnar value format (grafana#18391)
  Packages: Temporarily skip canary releases if packages build fail (grafana#18577)
  Update latest.json to latest stable version (grafana#18575)
  Docs: Update changelog for v6.3.3 (grafana#18569)
  Graph: Fixed issue clicking on series line icon (grafana#18563)
  grafana/toolkit: Unpublish previous "next" version when releasing a new one (grafana#18552)
  Toolkit: write PR report to a folder with the circle build number (grafana#18560)
  CI: Fail build if yarn.lock is not up to date (grafana#18555)
  Chore: Updates react-dependant packages to address react warnings (grafana#18549)
  Prometheus: Fix regression of rerunning query on legend/interval change (grafana#18147)
  Explore/Prometheus: More consistently allows for multi-line queries (grafana#18362)
  Login: Fixes undefined redirect (grafana#18545)
  Plugins: expose react-redux, redux (grafana#18501)
  TimeSeries: assume values are all numbers (grafana#18540)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Aug 15, 2019
* grafana/master:
  DataFrame: convert from row based to a columnar value format (grafana#18391)
  Packages: Temporarily skip canary releases if packages build fail (grafana#18577)
  Update latest.json to latest stable version (grafana#18575)
  Docs: Update changelog for v6.3.3 (grafana#18569)
  Graph: Fixed issue clicking on series line icon (grafana#18563)
  grafana/toolkit: Unpublish previous "next" version when releasing a new one (grafana#18552)
  Toolkit: write PR report to a folder with the circle build number (grafana#18560)
  CI: Fail build if yarn.lock is not up to date (grafana#18555)
  Chore: Updates react-dependant packages to address react warnings (grafana#18549)
  Prometheus: Fix regression of rerunning query on legend/interval change (grafana#18147)
  Explore/Prometheus: More consistently allows for multi-line queries (grafana#18362)
  Login: Fixes undefined redirect (grafana#18545)
  Plugins: expose react-redux, redux (grafana#18501)
  TimeSeries: assume values are all numbers (grafana#18540)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Aug 15, 2019
* grafana/master: (156 commits)
  DataFrame: convert from row based to a columnar value format (grafana#18391)
  Packages: Temporarily skip canary releases if packages build fail (grafana#18577)
  Update latest.json to latest stable version (grafana#18575)
  Docs: Update changelog for v6.3.3 (grafana#18569)
  Graph: Fixed issue clicking on series line icon (grafana#18563)
  grafana/toolkit: Unpublish previous "next" version when releasing a new one (grafana#18552)
  Toolkit: write PR report to a folder with the circle build number (grafana#18560)
  CI: Fail build if yarn.lock is not up to date (grafana#18555)
  Chore: Updates react-dependant packages to address react warnings (grafana#18549)
  Prometheus: Fix regression of rerunning query on legend/interval change (grafana#18147)
  Explore/Prometheus: More consistently allows for multi-line queries (grafana#18362)
  Login: Fixes undefined redirect (grafana#18545)
  Plugins: expose react-redux, redux (grafana#18501)
  TimeSeries: assume values are all numbers (grafana#18540)
  Login: Angular to React (grafana#18116)
  InfoTooltip: Info icon with tooltip (grafana#18478)
  Annotations: Fix failing annotation query when time series query is cancelled (grafana#18532)
  remotecache: support SSL with redis (grafana#18511)
  QueryData: Handle that response data must be array (grafana#18504)
  React: Rename deprecated UNSAFE_componentWillReceiveProps (grafana#18526)
  ...
ryantxu added a commit to ryantxu/grafana that referenced this pull request Aug 19, 2019
* grafana/master: (202 commits)
  Azure Monitor and Log Analytics converted and separated into components (grafana#18259)
  Rewrite user profile edit to react (grafana#17917)
  Docs: remove codecov badge (grafana#18623)
  Prometheus: Prevents panel editor crash when switching to Prometheus datasource (grafana#18616)
  Chore: Rename Popper to Popover (grafana#18543)
  SingleStat: add a gauge migration call to action button in the editor (grafana#18604)
  Build: update revive dependency (grafana#18585)
  LDAP: multildap + ldap integration (grafana#18588)
  Docker: switch docker image to alpine base with phantomjs support (grafana#18468)
  Backend: Adds support for HTTP/2 (grafana#18358)
  Explore: Fixes error when switching from prometheus to loki data sources (grafana#18599)
  TimePicker: Set time to to 23:59:59 when setting To time using calendar (grafana#18595)
  Prometheus: Return labels in query results (grafana#18535)
  Docs: Update changelog and docs for annotation region change (grafana#18593)
  Refactor: move KeyValue and deprecation warning to @grafana/data (grafana#18582)
  Annotations: use a single row to represent a region (grafana#17673)
  Docs: Update upgrading guide (grafana#18547)
  Docs: Adds tests requirement to bugs checklist (grafana#18576)
  DataFrame: convert from row based to a columnar value format (grafana#18391)
  Packages: Temporarily skip canary releases if packages build fail (grafana#18577)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants