feat: support multiple alert in a panel #20822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okhowang
force-pushed
the
feat/multi-alert
branch
3 times, most recently
from
9dbd108
to
dd64a50
Compare
okhowang
force-pushed
the
feat/multi-alert
branch
from
dd64a50
to
e4fcb85
Compare
|
Thank for contributing! For multiple reasons we think having multiple alert rules per panel is problematic, but the main problem is that our plans for alerting are to make alert rules more standalone and separate from the Graph panel and the dashboard. Creating and managing alert rules via dashboard (panel model) updates was a mistake. |
|
Hope to share more on our future plans for alerting, and get started in this project next year. |
and when will be that ? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
to support multiple alert in a panel.
Which issue(s) this PR fixes:
Fixes #7832
Special notes for your reviewer:
avoiding rewrite too much code
in frontend, I wrap angular component
AlertTabCtrlinto a list for react componentAlertTabin backend, just modify
getAlertFromPanelsfor get multiple alerts from a panel