Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More datasource funcs poc #21047

Merged
merged 20 commits into from
Jan 10, 2020
Merged

More datasource funcs poc #21047

merged 20 commits into from
Jan 10, 2020

Conversation

shavonn
Copy link
Contributor

@shavonn shavonn commented Dec 11, 2019

No description provided.

@ryantxu
Copy link
Member

ryantxu commented Dec 12, 2019

Can we move these functions to thier own file under utils? essentially move lines 275-360 to utils/datasource.ts and then add it to the index in that folder.

We aim to keep the 'types' folder just types and not utility functions

@shavonn shavonn closed this Dec 12, 2019
@dprokop
Copy link
Member

dprokop commented Dec 12, 2019

@shavonn I see this PR is closed - is it by accident?

@shavonn shavonn reopened this Dec 12, 2019
@stale
Copy link

stale bot commented Dec 27, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale Issue with no recent activity label Dec 27, 2019
@stale stale bot removed the stale Issue with no recent activity label Jan 7, 2020
Copy link
Member

@ryantxu ryantxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we try applying keyof to the other string functions?

@shavonn
Copy link
Contributor Author

shavonn commented Jan 7, 2020

@ryantxu The reset funcs will be on keys that will always be diff between datasources and will only require the key as a param and no data so the most that can be done is:
<J, S extends {} = KeyValue> and then key would be string
Like in updateDatasourcePluginSecureJsonDataOption. Do that?

@shavonn shavonn marked this pull request as ready for review January 10, 2020 01:18
Copy link
Member

@ryantxu ryantxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a big improvement to me -- if we need to tweak it, lets do that more in another issue

@shavonn shavonn merged commit a7509d2 into master Jan 10, 2020
@shavonn shavonn deleted the more-datasource-funcs-poc branch January 10, 2020 19:26
@shavonn shavonn restored the more-datasource-funcs-poc branch January 13, 2020 00:54
@shavonn shavonn deleted the more-datasource-funcs-poc branch January 16, 2020 22:05
@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants