-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More datasource funcs poc #21047
More datasource funcs poc #21047
Conversation
… static selects as constants
…rdize-cloudwatch-config-editor
…rdize-cloudwatch-config-editor
…rdize-cloudwatch-config-editor
…rdize-cloudwatch-config-editor
…rdize-cloudwatch-config-editor
Can we move these functions to thier own file under utils? essentially move lines 275-360 to We aim to keep the 'types' folder just types and not utility functions |
public/app/plugins/datasource/cloudwatch/components/ConfigEditor.tsx
Outdated
Show resolved
Hide resolved
@shavonn I see this PR is closed - is it by accident? |
This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we try applying keyof
to the other string functions?
@ryantxu The reset funcs will be on keys that will always be diff between datasources and will only require the key as a param and no data so the most that can be done is: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a big improvement to me -- if we need to tweak it, lets do that more in another issue
No description provided.