Alerting: new min_interval_seconds option to enforce a minimum evaluation frequency #21188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will let operator enforce a minimum time for the scheduler to enqueue evaluations
aknuds1
approved these changes
Dec 19, 2019
marefr
requested changes
Dec 30, 2019
| const frequencySecs = kbn.interval_to_seconds(this.alert.frequency); | ||
| if (frequencySecs < this.alertingMinIntervalSecs) { | ||
| this.frequencyWarning = | ||
| 'The rule will be evaluated every ' + |
There was a problem hiding this comment.
Would like to change the warning text, but not exactly sure to what. Suggestions:
- "A minimum evaluation interval of
this.alertingMinIntervalhave been configured and will be used for this rule" - "A minimum evaluation interval have been configured. This rule will be evaluated every
this.alertingMinInterval"
@oddlittlebird maybe have some input on the warning text?
Evaluation interval is what we're referring to in docs: https://grafana.com/docs/grafana/latest/alerting/rules/#name-and-evaluation-interval
There was a problem hiding this comment.
Both of those warning texts are very passive. It makes it hard to understand what is happening to what. Of the two listed, the second is better. I would suggest something like:
"<rule name> will be evaluated every <this.alertingMinInterval>. You can change this by adjusting the <whatever> value."
Either that or the second sentence should be other useful information about why they might want to increase or lower the value.
marefr
requested changes
Jan 10, 2020
papagian
changed the title
ryantxu
added a commit
that referenced
this pull request
Jan 15, 2020
…ation * origin/master: Explore: Fix timepicker when browsing back after switching datasource (#21454) Add disabled option for cookie samesite attribute (#21472) Chore: Adds basic alerting notification service tests (#21467) ImportDashboardCommand: Validate JSON fields (#21350) Docs: add test for website build (#21364) Fix: when clicking a plot on a touch device we won't display the annotation menu (#21479) Backend Plugins: add a common implementation (#21408) Alerting: new min_interval_seconds options to enforce a minimum eval frequency (#21188) Panel: Use Tabs in panel inspector (#21468)
ryantxu
added a commit
that referenced
this pull request
Jan 15, 2020
* origin/master: ImportDashboardCommand: Validate JSON fields (#21350) Docs: add test for website build (#21364) Fix: when clicking a plot on a touch device we won't display the annotation menu (#21479) Backend Plugins: add a common implementation (#21408) Alerting: new min_interval_seconds options to enforce a minimum eval frequency (#21188) Panel: Use Tabs in panel inspector (#21468) Docs: Update rpm install (#21475)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It will allow operator to force alerting scheduler to honor a minimum frequency when Tick() is called.
This is continuation of work in #17279. It introduces a commit with the suggested UI modification on top of the existing commits. I have opened a new PR because I was unable to push commits to the old PR's source branch.
Which issue(s) this PR fixes:
Fixes #14447
Special notes for your reviewer: